fix(web): fix bugs in createDefaultKeep, extend unit testing 🚂 🔪#15950
Open
jahorton wants to merge 1 commit into
Open
fix(web): fix bugs in createDefaultKeep, extend unit testing 🚂 🔪#15950jahorton wants to merge 1 commit into
jahorton wants to merge 1 commit into
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
Bot
changed the title
jahorton
force-pushed
the
change/web/rework-traversalless-prediction
branch
4 times, most recently
from
ae6030c to
c647016
Compare
jahorton
changed the base branch from
change/web/rework-traversalless-prediction
to
feat/web/multi-token-predict-core
jahorton
force-pushed
the
fix/web/create-default-keep
branch
from
023a560 to
4d60591
Compare
keymanapp-test-bot
Bot
changed the title
jahorton
force-pushed
the
feat/web/multi-token-predict-core
branch
from
754d792 to
f9f9b08
Compare
jahorton
force-pushed
the
fix/web/create-default-keep
branch
from
4d60591 to
21ecf7a
Compare
jahorton
force-pushed
the
feat/web/multi-token-predict-core
branch
from
f9f9b08 to
25f7f16
Compare
jahorton
force-pushed
the
fix/web/create-default-keep
branch
from
21ecf7a to
b079a74
Compare
jahorton
force-pushed
the
feat/web/multi-token-predict-core
branch
from
25f7f16 to
8fa77c0
Compare
jahorton
force-pushed
the
fix/web/create-default-keep
branch
from
b079a74 to
6e557ee
Compare
jahorton
force-pushed
the
feat/web/multi-token-predict-core
branch
3 times, most recently
from
f75eb1e to
9db4da8
Compare
jahorton
force-pushed
the
feat/web/multi-token-predict-core
branch
from
9db4da8 to
f7c1bfa
Compare
jahorton
force-pushed
the
fix/web/create-default-keep
branch
from
6e557ee to
e89f059
Compare
jahorton
force-pushed
the
feat/web/multi-token-predict-core
branch
from
f7c1bfa to
1a7bb31
Compare
jahorton
force-pushed
the
fix/web/create-default-keep
branch
3 times, most recently
from
dce7124 to
8fd9ef9
Compare
It turns out that #15766 did not perfectly address all cases for generation of default "keep" suggestions. This PR will remedy the situation. Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
fix/web/create-default-keep
branch
from
8fd9ef9 to
9a26be5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that #15766 did not perfectly address all cases for generation of default "keep" suggestions... or perhaps they merely need extending to better operate in cases where input affects multiple tokens. Either way, this PR will remedy the situation.
Build-bot: skip build:web
Test-bot: skip