feat: shared site testing script and move to linkinator#97
Open
mcdurdin wants to merge 1 commit into
Open
Conversation
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
force-pushed
the
feat/linkinator-and-central-test-script
branch
from
741832a to
c855186
Compare
Relates-to: keymanapp/keyman.com#788 Test-bot: skip
mcdurdin
force-pushed
the
feat/linkinator-and-central-test-script
branch
from
c855186 to
df4837e
Compare
ermshiperete
requested changes
Jun 15, 2026
| local CONTAINER_PORT="$2" | ||
| local TEST_PATH="$3" | ||
| shift 3 | ||
| local SKIP_PATHS=("$*") |
Contributor
There was a problem hiding this comment.
Suggested change
| local SKIP_PATHS=("$*") | |
| local SKIP_PATHS=("$@") |
| shift 2 | ||
| local skipPaths skip skipParams=() | ||
| if [[ $# -gt 1 ]]; then | ||
| skipPaths=("$*") |
Contributor
There was a problem hiding this comment.
Suggested change
| skipPaths=("$*") | |
| skipPaths=("$@") |
| local LINK_RESULT | ||
| echo "TIER_TEST" > tier.txt | ||
|
|
||
| # from commands.inc.sh |
Contributor
There was a problem hiding this comment.
Which commands.inc.sh ?
| @@ -0,0 +1,93 @@ | |||
| # shellcheck shell=bash | |||
Contributor
There was a problem hiding this comment.
Suggested change
| # shellcheck shell=bash | |
| # shellcheck shell=bash | |
| # Keyman is copyright (C) SIL Global. MIT License. |
| @@ -1,5 +1,7 @@ | |||
| # Common docker functions. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| # Common docker functions. | |
| # shellcheck shell=bash | |
| # Keyman is copyright (C) SIL Global. MIT License. | |
| # | |
| # Common docker functions. |
| # | ||
| function do_test_unit_tests() { | ||
| local CONTAINER="$1" | ||
| docker exec "${CONTAINER}" sh -c "vendor/bin/phpunit --testdox ${builder_extra_params[*]}" |
Contributor
There was a problem hiding this comment.
Suggested change
| docker exec "${CONTAINER}" sh -c "vendor/bin/phpunit --testdox ${builder_extra_params[*]}" | |
| docker exec "${CONTAINER}" sh -c "vendor/bin/phpunit --testdox ${builder_extra_params[@]}" |
| shift 3 | ||
| local SKIP_PATHS=("$*") | ||
|
|
||
| local LINK_RESULT |
Contributor
There was a problem hiding this comment.
This needs to be initialized, otherwise we return uninitialized value if we don't do link checks.
Suggested change
| local LINK_RESULT | |
| local LINK_RESULT=0 |
| local testPath="$2" | ||
| shift 2 | ||
| local skipPaths skip skipParams=() | ||
| if [[ $# -gt 1 ]]; then |
Contributor
There was a problem hiding this comment.
Suggested change
| if [[ $# -gt 1 ]]; then | |
| if [[ $# -ge 1 ]]; then |
| # | ||
| function do_test_print_container_error_logs() { | ||
| local CONTAINER="$1" | ||
| if docker container logs "${CONTAINER}" --since "${TEST_START_TIME}" 2>&1 | grep -q 'php7'; then |
Contributor
There was a problem hiding this comment.
Can we add some check somewhere that we're still running the expected PHP version that outputs php7?
Makes me a bit nervous that PHP gets upgraded and we forget to upgrade this string which then causes silent failure (or rather non-failure) of this function.
| local SKIP_PATHS=("$*") | ||
|
|
||
| local LINK_RESULT | ||
| echo "TIER_TEST" > tier.txt |
Contributor
There was a problem hiding this comment.
What's the purpose of tier.txt ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates-to: keymanapp/keyman.com#788
Test-bot: skip