Skip to content

fix in-tree builds with apcu#100

Open
henderkes wants to merge 2 commits into
kjdev:masterfrom
henderkes:patch-1
Open

fix in-tree builds with apcu#100
henderkes wants to merge 2 commits into
kjdev:masterfrom
henderkes:patch-1

Conversation

@henderkes

@henderkes henderkes commented Jun 25, 2026

Copy link
Copy Markdown

the last commit makes apcu error if the file isn't found in $phpincludedir/ext/apcu/, but during in-tree builds the path is $abssrcdir/ext/apcu/.

Summary by CodeRabbit

  • Bug Fixes
    • Improved build detection for APCu so it can find the required headers in more environments.
    • Builds now handle source-tree header locations more reliably, reducing configuration failures and false “not found” messages.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9682ae7b-7869-429f-a8ee-5fb93ac4ae42

📥 Commits

Reviewing files that changed from the base of the PR and between 2db8c7c and ab85c7c.

📒 Files selected for processing (1)
  • config.m4
🚧 Files skipped from review as they are similar to previous changes (1)
  • config.m4

📝 Walkthrough

Walkthrough

config.m4 now falls back to the source tree include directory when APCu’s apc_serializer.h is missing from the current include path but present under ext/apcu/, before the APCu support check runs.

Changes

APCu include path fallback

Layer / File(s) Summary
Include path fallback in APCu setup
config.m4
phpincludedir is reassigned to $abs_srcdir when ext/apcu/apc_serializer.h is not found in the existing include directory but is available in the source tree.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • kjdev/php-ext-zstd#99: Also changes config.m4 APCu apc_serializer.h detection behavior and include-path handling.

Poem

I hopped through config.m4 with a grin,
Found apc_serializer.h tucked in within.
If the path looks away,
I’ll reroute and stay,
Then APCu can warm up and spin 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: fixing APCu-related in-tree build behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

crazywhalecc added a commit to crazywhalecc/static-php-cli that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant