chore(client): internalize jwt-decode (KNO-13812)#1021
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 17, 2026
kylemcd
force-pushed
the
kyle-kno-13812-internalize-jwt-decode-in-knocklabsclient-and-drop-the
branch
from
c9a48f5 to
66bf33e
Compare
🦋 Changeset detectedLatest commit: 66bf33e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kylemcd
deleted the branch
kyle-kno-13814-remove-the-clsx-dependency-from-knocklabsreact-native
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## kyle-kno-13814-remove-the-clsx-dependency-from-knocklabsreact-native #1021 +/- ##
========================================================================================================
+ Coverage 63.44% 63.56% +0.12%
========================================================================================================
Files 208 209 +1
Lines 10000 10059 +59
Branches 1280 1298 +18
========================================================================================================
+ Hits 6344 6394 +50
- Misses 3631 3640 +9
Partials 25 25
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Internalizes
jwt-decodein@knocklabs/clientand drops the runtime dependency. The package only base64url-decodes a JWT payload andJSON.parses it (no signature verification), so it is reimplemented as a small internal module.What changed
packages/client/src/jwt/— a dedicated folder containing the decoder (jwtDecode, theJwtPayloadtype, andInvalidTokenError).knock.ts(value) andinterfaces.ts(type), and updated the mock intest/knock.test.tsto target the internal module.packages/client/test/jwt.test.tscovering standard claims, custom-claim typing, unicode payloads, base64url padding, andInvalidTokenErrorcases.jwt-decodefrompackages/client/package.jsonand updated the lockfile (it was not a transitive dependency of anything else, so it is fully removed).Why: Part of the npm supply chain hardening effort.
@knocklabs/clientis published, so dropping the dependency also removes it from every consumer's install graph.Linear: KNO-13812
Stack (bottom → top) — npm supply chain hardening:
clsxfrom@knocklabs/reactjwt-decodein@knocklabs/client◀ this PRlodash.debouncein@knocklabs/reactfast-deep-equalin@knocklabs/react-coreChecklist
test/jwt.test.ts) and the existingknock.test.tssuite passes.