fix: inherit parent RouteNotFound handler for groups with middleware#2986
Open
leno23 wants to merge 1 commit into
Open
fix: inherit parent RouteNotFound handler for groups with middleware#2986leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
When a group registers middleware, reuse the most specific parent RouteNotFound handler instead of always falling back to the default JSON NotFoundHandler. Fixes labstack#2485
leno23
force-pushed
the
fix/group-routenotfound-fallback-2485
branch
from
3081f5e to
52f5079
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Group.Use()registers catch-all RouteNotFound routes for middleware execution, inherit the most specific parent RouteNotFound handler from the router treeNotFoundHandleronly when no parent handler existsFixes #2485
Problem
Groups created with middleware always registered the default JSON
NotFoundHandlerfor 404 cases, shadowing a custom rootRouteNotFoundhandler.Test plan
go test ./...TestGroupRouteNotFoundFallsBackToRootHandlerfrom the issue reproducerTestGroup_RouteNotFoundWithMiddlewareexpectations for inherited handlers