Document mail sender allow/block list commands#1744
Conversation
github-actions
Bot
added
domain/mail
📝 WalkthroughWalkthroughThis PR updates ChangesMail skill documentation
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
skills/lark-mail/SKILL.md (2)
115-117: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winClarify the
-hbootstrap order.The new “always run
-hfirst” rule conflicts with the earlier workflow step that starts by callinguser_mailboxes profile. Readers can’t tell whether that bootstrap call is exempt, so the onboarding sequence is ambiguous. Please align those two sections.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/lark-mail/SKILL.md` around lines 115 - 117, The onboarding sequence in the SKILL.md section is ambiguous because the new “always run -h first” rule conflicts with the earlier bootstrap step that starts with user_mailboxes profile. Update the workflow wording so it clearly states whether user_mailboxes profile is the exception or must also be preceded by -h, and make the steps in the relevant section consistent with that rule. Refer to the bootstrap guidance around user_mailboxes profile and the “首次使用任何命令前先查 -h” instruction when revising the sequence.
463-465: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winBroaden the duplicate-recipient warning.
The merge table says template recipients are appended without de-duplication for all five template-enabled shortcuts, but this warning only mentions
+reply/+reply-all. That leaves+sendand+draft-createable to produce silent duplicates with no heads-up. Either expand the warning scope or dedupe earlier.Suggested wording
-**Warning**：`+reply` / `+reply-all` + 模板且模板自带 tos/ccs/bccs 时，CLI 在 stderr 打印：... +**Warning**：所有支持 `--template-id` 的发信 shortcut（`+send` / `+draft-create` / `+reply` / `+reply-all` / `+forward`）在模板收件人与用户收件人重叠时都可能产生重复收件人：...🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/lark-mail/SKILL.md` around lines 463 - 465, The duplicate-recipient warning in SKILL.md is too narrow: it only mentions `+reply` / `+reply-all`, but the template merge behavior applies to all template-enabled shortcuts. Update the warning text near the template recipient rules to cover `+send` and `+draft-create` as well, or adjust the logic/docs around the template handling section so the warning matches the actual shortcut set and references the same recipient-appending behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@skills/lark-mail/SKILL.md`:
- Around line 115-117: The onboarding sequence in the SKILL.md section is
ambiguous because the new “always run -h first” rule conflicts with the earlier
bootstrap step that starts with user_mailboxes profile. Update the workflow
wording so it clearly states whether user_mailboxes profile is the exception or
must also be preceded by -h, and make the steps in the relevant section
consistent with that rule. Refer to the bootstrap guidance around user_mailboxes
profile and the “首次使用任何命令前先查 -h” instruction when revising the sequence.
- Around line 463-465: The duplicate-recipient warning in SKILL.md is too
narrow: it only mentions `+reply` / `+reply-all`, but the template merge
behavior applies to all template-enabled shortcuts. Update the warning text near
the template recipient rules to cover `+send` and `+draft-create` as well, or
adjust the logic/docs around the template handling section so the warning
matches the actual shortcut set and references the same recipient-appending
behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 67941e16-a409-4d83-8cf9-ddda42480327
📒 Files selected for processing (2)
skill-template/domains/mail.mdskills/lark-mail/SKILL.md
🚧 Files skipped from review as they are similar to previous changes (1)
- skill-template/domains/mail.md
chumbleyneria
left a comment
chumbleyneria
left a comment
There was a problem hiding this comment.
🤖 AI Review | CR 汇总 | 有风险（1 个 P2）
| | `user_mailboxes.search` | `mail:user_mailbox.message:readonly` | | ||
| | `user_mailbox.allow_senders.batch_create` | `mail:user_mailbox.message:modify` | | ||
| | `user_mailbox.allow_senders.batch_remove` | `mail:user_mailbox.message:modify` | | ||
| | `user_mailbox.allow_senders.list` | `mail:user_mailbox.message:modify` | |
There was a problem hiding this comment.
🤖 AI Review | [P2 正确性] list 命令被误标成写权限
这里把 user_mailbox.allow_senders.list 标成 mail:user_mailbox.message:modify，下一行 blocked_senders 也一样。但 registry 元数据和技术方案都声明 list 同时支持 mail:user_mailbox.message:readonly / :modify，查询名单不应引导用户申请写权限；只具备 readonly 的应用也会被文档误导为不能执行 list。
修复建议: 将两个 list 行改成包含 mail:user_mailbox.message:readonly（可写成 readonly / modify 均可），并确保生成后的 skill 权限表与 registry 元数据一致。
如有疑问或认为判断不准确，欢迎直接回复讨论。
1 participant
Updates the generated mail CLI documentation for user mailbox sender allow and block list management. The refreshed artifacts describe the sender list operations so the CLI reference matches the available mail API surface.
Summary by CodeRabbit