fix: Codex plugin manifest name mismatch - #126
Open
Vadman97 wants to merge 1 commit into
Open
Conversation
Skill eval results
Only suites whose source actually changed since their last recorded score were re-run. Soft-failing while we stabilise the baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.codex-plugin/plugin.jsonwith thelaunchdarklyname advertised by the marketplaceWithout this,
codex plugin add launchdarkly@launchdarkly-ai-toolingfails with:plugin.json name launchdarkly-mcp does not match marketplace plugin name launchdarkly.Validation
python3 -m unittest discover -s tests -p "test_*.py"python3 scripts/validate_skills.pySupersedes #120 (same commit,
089cd09). That PR was opened from a fork, sopull_requestruns could not seesecrets.ANTHROPIC_API_KEYand every Skill Evals suite errored withANTHROPIC_API_KEY environment variable is not set→ 0% against the 75% threshold. Re-opening from a branch in this repo so the evals actually run.Note
Low Risk
Metadata-only manifest rename plus a CI guard; no runtime MCP or skill behavior changes.
Overview
Renames the Codex plugin id in
.codex-plugin/plugin.jsonfromlaunchdarkly-mcptolaunchdarklyso it matches the root entry in.claude-plugin/marketplace.json. That mismatch blockedcodex plugin add launchdarkly@launchdarkly-ai-tooling.Adds
tests/test_plugin_manifests.py, a unittest that loads both manifests and asserts the Codexnameequals the marketplace plugin with"source": ".".Reviewed by Cursor Bugbot for commit 089cd09. Bugbot is set up for automated code reviews on this repo. Configure here.