fix(experiments): A/A route returns components all false [EXPT-4665] - #138
Open
hsadhvani wants to merge 1 commit into
Open
fix(experiments): A/A route returns components all false [EXPT-4665]#138hsadhvani wants to merge 1 commit into
hsadhvani wants to merge 1 commit into
Conversation
Skill eval results
Only suites whose source actually changed since their last recorded score were re-run. Soft-failing while we stabilise the baseline. |
ericoh-ld
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the machine contract in the
launchdarkly-experiment-hypothesis-builderskill soroute: aareportscomponentsallfalse(consistent withjunk) instead of alltrue. Raised by Nam in #proj-exp-ai: an A/A test asserts no change or effect, so all-true was inconsistent and made us lean on the model routing A/A perfectly. The builder ignores components for A/A (it renders the A/A badge), so this is a contract-only change.Kept byte-identical to the o11y
experiment-hypothesisskill's contract (companion o11y PR).Testing approaches
aacomponents are all false.Feature flags
N/A
Note
Low Risk
Single-line skill markdown contract clarification with no code or security impact.
Overview
Updates the structured JSON contract in
launchdarkly-experiment-hypothesis-buildersoroute: aadocumentscomponentsallfalse, same asjunk, instead of alltruelikerewrite.That matches the product model (A/A asserts no change/effect; the rubric is replaced by the A/A badge) and keeps the contract aligned with the o11y
experiment-hypothesisskill for shared grading. Documentation-only in this repo—no runtime behavior change in the builder beyond what callers infer from the contract.Reviewed by Cursor Bugbot for commit 7d6f293. Bugbot is set up for automated code reviews on this repo. Configure here.