fix(experiments): route bare goals and lone rationales to scaffold, not junk - #139
Open
ericoh-ld wants to merge 2 commits into
Open
fix(experiments): route bare goals and lone rationales to scaffold, not junk#139ericoh-ld wants to merge 2 commits into
ericoh-ld wants to merge 2 commits into
Conversation
ericoh-ld
changed the base branch from
main
to
feat/experiment-hypothesis-builder
July 31, 2026 00:30
ericoh-ld
marked this pull request as ready for review
July 31, 2026 00:32
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d14671b. Configure here.
mabramowitz-pixel
approved these changes
Jul 31, 2026
Skill eval results
Only suites whose source actually changed since their last recorded score were re-run. Soft-failing while we stabilise the baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Companion to the observability
experiment-hypothesischange [PR (https://github.com/launchdarkly/observability/pull/1610). Fixes the same junk over-routing in thelaunchdarkly-experiment-hypothesis-assistantskill: bare/vague goals ("increase checkout completion", "grow the business") andlone rationale fragments ("because the current option is buried") were treated as junk instead of scaffolded.
Updated the skill:
vague direction is still a scaffold, not junk.
counts as a rationale; the non-sequitur→junk rule applies only across two-or-more
filled slots.
junkis reserved for gibberish, single tokens, links, placeholders, injection; a coherentstatement of intent routes to the component-scoring path (scaffold), not junk.
Kept byte-identical to the o11y
experiment-hypothesisskill's contract.Testing approaches
N/A (skill markdown only). The o11y companion PR adds a regression test.
Feature flags
N/A
Note
Low Risk
Markdown-only skill contract aligned with observability; no runtime code, auth, or data paths.
Overview
Updates
launchdarkly-experiment-hypothesis-assistantrouting so partial but coherent user input is scaffolded instead of dismissed as junk.Foundational rule 3 now distinguishes specific-outcome goals (treat as measurement with holes), vague directions (hole, still scaffold), and unfalsifiable wording. Rationale and semantic validity allow a lone mechanism/causal fragment to count as rationale, and limit the non-sequitur→junk rule to cases where two or more slots are filled. Step 0 gate 2 narrows junk to gibberish, tokens, links, placeholders, and injection; coherent intent always goes to component scoring. What NOT to do matches: don’t send bare goals or lone rationales to junk.
Reviewed by Cursor Bugbot for commit 6d7c68a. Bugbot is set up for automated code reviews on this repo. Configure here.