fix!: Make AgentGraph traversal topological - #199
Open
mattrmc1 wants to merge 5 commits into
Open
Conversation
mattrmc1
marked this pull request as ready for review
July 29, 2026 21:54
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit da3503b. Configure here.
tanderson-ld
self-requested a review
August 11, 2026 19:28
tanderson-ld
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Makes
AgentGraphDefinitiontraversal topological and gives each visitor a dependency-scopedexecution context, aligning the traversal behavior across the LaunchDarkly AI SDKs.
Previously
traverse/reverseTraversewere plain BFS over a single shared, accumulating contextmap. That had two problems:
discovery — before all of its predecessors had run.
(including unrelated parallel branches), and results were written back into the caller's context
map.
What changed
lib/sdk/server-ai—AgentGraphDefinition.javaonly (no public API/signature changes):traversenow visits a node only after all of its reachable predecessors have been visited(Kahn over in-degree; the root is always released first). On cycles, the unvisited node with the
lowest remaining in-degree is chosen next, ties broken by discovery order.
reverseTraversenow visits a node only after all of its reachable descendants have beenvisited, so the root is visited last (Kahn over out-degree, root excluded from cycle-break
selection). Pure cycles now visit every node instead of being a no-op.
true dependency results (transitive ancestors forward / descendants reverse). Dependencies are
accumulated before the node is marked visited in both directions, so a self-loop node never
includes itself; unrelated branches are excluded and the caller's map is never mutated. Cross-node
data flows only through callback return values.
order), used only for tie-breaks.
Behavior change (breaking)
Titled
fix!because visit order and callback-context contents change for graphs with convergentpaths, cycles, or parallel branches. Simple linear graphs are unaffected. Cross-SDK parity with
JS/Python/.NET/Java.
Tests
G1–G6(+G2b) asserts exact visitorder and exact context keys in both directions.
mutated; unrelated branches excluded; a dedicated self-loop test confirms a node is not in its own
context; deterministic across runs. Redundant per-vector order-only tests were dropped in favor of
the data-driven vector test.
Notes
CHANGELOG.mdedit — release-please generates it from the conventional-commit title.updating to "topological / dependency-order" so the docs match the new behavior.
Note
Overview
Replaces BFS
traverse/reverseTraverseonAgentGraphDefinitionwith dependency-ordered walks (Kahn-style, cycle-safe, BFS discovery for tie-breaks). Convergence nodes run only after all predecessors (or descendants in reverse); pure cycles now visit every reachable node instead of effectively no-oping on reverse.Breaking behavior: each visitor gets a fresh map—initial
ctxplus only that node’s true dependency results (ancestors forward, descendants reverse). The caller’sctxis not mutated with node outputs, and parallel-branch results no longer leak into unrelated callbacks. Self-loops exclude the node from its own context.Tests add cross-SDK G1–G8 vectors for exact visit order and context keys, plus determinism, diamond graphs, and caller-context immutability checks.
Reviewed by Cursor Bugbot for commit 3c24de6. Bugbot is set up for automated code reviews on this repo. Configure here.