Conversation
BlobSourceFs resolved a key against the store root without normalizing or checking containment, so a key with `..` segments or an absolute path escaped the root — every read/write/delete method (has/content/get/size/lastModified/ walk/put/delete) was affected. This is the root cause behind the traversal reachable through request-derived keys in the 3D-tiles and resources endpoints. Enforce the invariant in canHandle: the normalized resolved path must start with the normalized root. Every method already gates on canHandle (directly or via has), so a traversal key is now treated as "not handled" — a no-op or not-found — instead of escaping the store. Also harden BlobCacheImpl.getCachePath, which built a cache path from the blob key and the (source-provided) ETag: reduce the ETag to safe filename characters and reject a cache path that would resolve outside the cache directory. Adds BlobSourceFsContainmentSpec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlobSourceFs resolved a key against the store root without normalizing or checking containment, so a key with
..segments or an absolute path escaped the root — every read/write/delete method (has/content/get/size/lastModified/ walk/put/delete) was affected. This is the root cause behind the traversal reachable through request-derived keys in the 3D-tiles and resources endpoints.Enforce the invariant in canHandle: the normalized resolved path must start with the normalized root. Every method already gates on canHandle (directly or via has), so a traversal key is now treated as "not handled" — a no-op or not-found — instead of escaping the store.
Also harden BlobCacheImpl.getCachePath, which built a cache path from the blob key and the (source-provided) ETag: reduce the ETag to safe filename characters and reject a cache path that would resolve outside the cache directory.
Adds BlobSourceFsContainmentSpec.