Implement self ref fk ordering#322
Merged
rtibbles merged 12 commits intoJun 3, 2026
Merged
Conversation
bjester
reviewed
Apr 30, 2026
bjester
reviewed
May 4, 2026
ozer550
force-pushed
the
implement-self-ref-fk-ordering
branch
from
59d644d to
aff0bbc
Compare
bjester
force-pushed
the
implement-self-ref-fk-ordering
branch
from
aff0bbc to
22635f3
Compare
bjester
force-pushed
the
implement-self-ref-fk-ordering
branch
from
22635f3 to
b19197b
Compare
bjester
reviewed
Jun 2, 2026
| ) | ||
|
|
||
| parent = Store.objects.filter( | ||
| id=Cast(OuterRef("_self_ref_fk"), UUIDField()), |
Member
There was a problem hiding this comment.
I added the Cast here, as postgres complained about a mismatch in type.
bjester
approved these changes
Jun 2, 2026
Member
bjester
left a comment
bjester
left a comment
There was a problem hiding this comment.
I approve of @ozer550's changes!
As for my changes, I resolved merge conflicts, fixed a postgres error, ensured our buffered chunks are always partitioned by model, and did some refactoring for partitioned buffers and self-ref FK lookups.
rtibbles
approved these changes
Jun 3, 2026
Member
rtibbles
left a comment
rtibbles
left a comment
There was a problem hiding this comment.
No concerns from a read through, and the implementation matches the spec to my eyes. No obvious artifacts from the merge conflict resolution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce deterministic ordering support for self-referential foreign key (FK) models during sync by adding a _self_ref_order field to Morango store records, allowing store/buffer rows to be processed parent-before-child in a streaming-friendly way. Adds a morango_ordering hook for syncable models so Morango can order querysets consistently (with nulls last), and adds a SELF_REF_ORDER capability to negotiate support between peers and preserve backwards compatibility.
TODO
Reviewer guidance
If you PR has a significant size, give the reviewer some helpful remarks
Issues addressed
closes #297
Documentation
If the PR has documentation, link the file here (either .rst in your repo or if built on Read The Docs)