Add some node-load-balancing test coverage#4404
Open
roystgnr wants to merge 3 commits into
Open
Conversation
Member
Author
|
Huh, maybe that's why I never opened up a PR for this - we need either a behavior change or more complicated scripting for the petscpartitioner option not to break But on the other hand, that |
This is consistent what we do with other partitioner objects, e.g. without Parmetis we fall back on Metis, without Metis we fall back on SFC, etc. But mostly I'm just being lazy because I want to add test coverage for this option without futzing with making sure the tests are enabled if-and-only-if PETSc is.
I ran into some trouble with the PETSc node partitioners; don't have time to debug any time soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I never got around to upgrading these tests to "rigorous testing of partitioner quality" rather than "testing to see if those code paths outright crash or corrupt partitioning", so this commit languished, but even a little test coverage here is better than nothing.