NURBS sphere tests#4475
Open
roystgnr wants to merge 5 commits into
Open
Conversation
We don't really expect much improvement here but we should make sure we're not screwing anything up.
I don't think these are culprits, but build_sphere() is kinda slow in 3D and I want to see if there's anything easy to fix there.
Member
Author
|
Wait a minute, I'm an idiot. Should have looked at the git diff before opening the PR. My performance bug was caused by some heavyweight tests I hacked into place while looking into a possible correctness bug. I'm not seeing stupidly slow (12s in opt mode!) results when tests get 448 elements out of |
These were just running slowly because I accidentally left in debugging code that gave them 3 extra refinements, 500 times too many hexes in the intermediate stage.
Member
Author
|
Yeah, with the overrefined runs removed we're down to a 30th of a second for all the AllRBB tests in opt mode, half a second in dbg. Much better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plus a couple things thrown in when I caught a bug in a previous test and when I was looking at performance of some of the new tests.