Skip to content

New Provider: ParsPack#15

Closed
ahmafi wants to merge 5 commits into
libdns:masterfrom
ahmafi:master
Closed

New Provider: ParsPack#15
ahmafi wants to merge 5 commits into
libdns:masterfrom
ahmafi:master

Conversation

@ahmafi

@ahmafi ahmafi commented Jun 26, 2026

Copy link
Copy Markdown

Hi, I have created implementation for parspack.ir.
The API reference can be found here.

There is one problem with the tests:

=== RUN   TestParsPackProvider
=== RUN   TestParsPackProvider/ListZones
    libdnstest.go:240: Found 2 zones
    libdnstest.go:248: Zone: shoplee.ir.
    libdnstest.go:248: Zone: testdomain.ir.
=== RUN   TestParsPackProvider/GetRecords
    libdnstest.go:269: Found 2 records in zone testdomain.ir.
    libdnstest.go:278: Record: @ 24h0m0s NS plateau.parspack.net.
    libdnstest.go:278: Record: @ 24h0m0s NS valley.parspack.net.
=== RUN   TestParsPackProvider/AppendRecords
    libdnstest.go:293: Creating test records for append operation
    libdnstest.go:381: Appending 8 new records
    libdnstest.go:390: Appended 8 records successfully
    libdnstest.go:392: Verifying appended records exist in zone
=== RUN   TestParsPackProvider/SetRecords
    libdnstest.go:409: Creating preserved record that should not be affected by SetRecords
    libdnstest.go:422: Created preserved record: test-set-preserve
    libdnstest.go:467: Setting initial records: 6 records of various types
    libdnstest.go:470: SetRecords (initial) failed: Store DNS Record Failed. Message:The record.flags must not be greater than 0.
=== RUN   TestParsPackProvider/DeleteRecords
    libdnstest.go:581: Creating test records for deletion
    libdnstest.go:658: Creating 7 records to be deleted later
    libdnstest.go:663: Created 7 records successfully
    libdnstest.go:665: Deleting the created records
    libdnstest.go:674: Deleted 7 records successfully
    libdnstest.go:676: Verifying records were actually deleted
--- FAIL: TestParsPackProvider (136.29s)
    --- PASS: TestParsPackProvider/ListZones (0.85s)
    --- PASS: TestParsPackProvider/GetRecords (1.95s)
    --- PASS: TestParsPackProvider/AppendRecords (54.19s)
    --- FAIL: TestParsPackProvider/SetRecords (26.50s)
    --- PASS: TestParsPackProvider/DeleteRecords (50.44s)
FAIL
exit status 1
FAIL    github.com/libdns/parspack/libdnstest   136.290s

I think we can set the flags in all the tests to 0 instead of 128, because that would probably have a better support between providers and 128 doesn't add more value (I guess!).

@mholt

mholt commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Thank you! I've created repos and added you to them so you can push this. Thanks for maintaining this.

@mholt mholt closed this Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants