ci: pin Node 24 in CLI workflow templates#23
Open
charliedowler wants to merge 1 commit into
Open
Conversation
The Lightdash CLI now requires Node.js 24 (Node 20 reached end-of-life in April 2026). These reusable workflows previously didn't pin a Node version, so they inherited the runner default — which is shifting to Node 24 but isn't guaranteed. Explicitly set `node-version: '24'` on every setup-node step so the CLI runs on its supported runtime regardless of runner default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Lightdash CLI now requires Node.js 24 (Node 20 reached end-of-life in April 2026, and the project has standardised on the current Active LTS).
These reusable workflow templates didn't pin a Node version on their
setup-nodesteps, so they ran the CLI on whatever Node the runner shipped by default. GitHub's hosted default is moving to Node 24, but that's not guaranteed across all runners/versions — so this makes it explicit.Change
Add
node-version: '24'to theactions/setup-nodestep in every workflow:compile.ymldeploy.ymlstart-preview.ymlclose-preview.ymlrefresh.ymllightdash-validate.ymlsetup-node@v3.4.1resolves Node versions from the live manifest, so it installs Node 24 fine without bumping the action itself.Notes
actions/setup-nodeis pinned to a fairly oldv3.4.1and could be bumped tov4.🤖 Generated with Claude Code