Skip to content

docs: complete Wave 5 child audits #654 #655 #656#792

Merged
ashleyshaw merged 1 commit into
developfrom
claude/wave-5-child-issues-batch-1
Jun 3, 2026
Merged

docs: complete Wave 5 child audits #654 #655 #656#792
ashleyshaw merged 1 commit into
developfrom
claude/wave-5-child-issues-batch-1

Conversation

@ashleyshaw
Copy link
Copy Markdown
Member

Summary\n- add audit report for #654 template inventory and standardization\n- add audit report for #655 issue-template to automation trigger mapping\n- add audit report for #656 issue-labeling rules in labeler.yml\n- close #654, #655, and #656 with completion comments\n\n## Validation\n- npm run lint:md\n\n## Reports\n- .github/reports/audits/2026-06-03-issue-template-inventory-standardization-audit-654.md\n- .github/reports/audits/2026-06-03-issue-template-automation-trigger-mapping-audit-655.md\n- .github/reports/audits/2026-06-03-issue-labeling-rules-in-labeler-audit-656.md

Add issue-template inventory, template-to-automation mapping, and labeler issue-rules audits for Wave 5 child issues.

Closes #654

Closes #655

Closes #656

https://claude.ai/code/session_f7cb7a8b-a13f-4467-b626-c66953488ccd
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 3, 2026

Warning

Review limit reached

@ashleyshaw, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 42 minutes and 45 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 4a3c3c84-2b2a-41a7-ae44-1266955ea967

📥 Commits

Reviewing files that changed from the base of the PR and between f62305a and b3cffc5.

📒 Files selected for processing (3)
  • .github/reports/audits/2026-06-03-issue-labeling-rules-in-labeler-audit-656.md
  • .github/reports/audits/2026-06-03-issue-template-automation-trigger-mapping-audit-655.md
  • .github/reports/audits/2026-06-03-issue-template-inventory-standardization-audit-654.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/wave-5-child-issues-batch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added status:needs-review Awaiting code review priority:normal Default priority labels Jun 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

🔍 Reviewer Summary for PR #792

CI Status:success
Files changed: 3
Risk Distribution: 0 critical, 3 high, 0 medium, 0 low

Recommendations

  • Ready to proceed pending human review

@github-actions github-actions Bot added type:chore Chore / small hygiene change type:documentation Documentation meta:needs-changelog Requires a changelog entry before merge labels Jun 3, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces three comprehensive audit reports detailing issue labeling rules, template-to-automation trigger mappings, and issue template standardization. The feedback focuses on correcting minor spelling inconsistencies to align with the repository's American English conventions, specifically updating terms like 'labelling', 'standardised', and 'favours'.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.


## Executive Summary

`.github/labeler.yml` is currently structured around PR-friendly signals (`head-branch`, `changed-files`) and has limited native issue-specific rule expression. Issue labelling exists in practice through the unified labeling workflow and agent heuristics rather than through rich issue-specific config rules.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the American English spelling convention used throughout the repository (e.g., labeling.yml, labeling.agent.js, and standardization), please use "labeling" instead of "labelling".

Suggested change
`.github/labeler.yml` is currently structured around PR-friendly signals (`head-branch`, `changed-files`) and has limited native issue-specific rule expression. Issue labelling exists in practice through the unified labeling workflow and agent heuristics rather than through rich issue-specific config rules.
.github/labeler.yml is currently structured around PR-friendly signals (head-branch, changed-files) and has limited native issue-specific rule expression. Issue labeling exists in practice through the unified labeling workflow and agent heuristics rather than through rich issue-specific config rules.

## Findings

1. `labeler.yml` has broad PR coverage and narrow issue-native coverage.
2. Issue labelling works, but largely through procedural logic in `labeling.agent.js`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the American English spelling convention used throughout the repository, please use "labeling" instead of "labelling".

Suggested change
2. Issue labelling works, but largely through procedural logic in `labeling.agent.js`.
2. Issue labeling works, but largely through procedural logic in labeling.agent.js.


## Executive Summary

Issue templates are structurally standardised, but they do not currently provide deterministic label/type triggers in frontmatter. Automation is therefore primarily workflow-driven and heuristic-driven after issue creation.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the American English spelling convention used throughout the repository (e.g., standardization in the other audit reports), please use "standardized" instead of "standardised".

Suggested change
Issue templates are structurally standardised, but they do not currently provide deterministic label/type triggers in frontmatter. Automation is therefore primarily workflow-driven and heuristic-driven after issue creation.
Issue templates are structurally standardized, but they do not currently provide deterministic label/type triggers in frontmatter. Automation is therefore primarily workflow-driven and heuristic-driven after issue creation.

- `head-branch` mappings drive many `type:*`, `status:*`, and `priority:*` outcomes.
- `changed-files` mappings drive `area:*` and `lang:*` labels.

Issue context has no branch or changed-files signals, so the current `.github/labeler.yml` rule design naturally favours PR events.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the American English spelling convention used throughout the repository, please use "favors" instead of "favours".

Suggested change
Issue context has no branch or changed-files signals, so the current `.github/labeler.yml` rule design naturally favours PR events.
Issue context has no branch or changed-files signals, so the current .github/labeler.yml rule design naturally favors PR events.

## Findings

1. Numbering and baseline standardization are good (26 sequential templates).
2. Direct template-driven labelling is not configured in issue templates (`labels` absent in all numbered templates).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the American English spelling convention used throughout the repository, please use "labeling" instead of "labelling".

Suggested change
2. Direct template-driven labelling is not configured in issue templates (`labels` absent in all numbered templates).
2. Direct template-driven labeling is not configured in issue templates (labels absent in all numbered templates).

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b3cffc53ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


| Template Set | Expected Automation | Current Status | Missing Pieces |
|---|---|---|---|
| Numbered issue templates (`01`-`26`) | Deterministic `type:*` and baseline triage labels on create | Partial (agent infers from text) | No template `labels`, no deterministic per-template mapping in config |
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Correct issue type inference coverage

For template-created issues without an existing type:* label, the inspected runtime path does not reliably infer the template type from text: scripts/agents/includes/status-enforcer.js applies default type:task before content detection, and scripts/agents/labeling.agent.js only has keywords for a subset of types, omitting several numbered templates such as epic, story, design, audit, help/support, release, and AI Ops. Marking the current status as “agent infers from text” can close #655 while missing the main automation gap: many templates still become generic tasks or duplicate type labels rather than deterministic template-specific types.

Useful? React with 👍 / 👎.

@ashleyshaw ashleyshaw merged commit 1ef36be into develop Jun 3, 2026
18 of 19 checks passed
@ashleyshaw ashleyshaw deleted the claude/wave-5-child-issues-batch-1 branch June 3, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta:needs-changelog Requires a changelog entry before merge priority:normal Default priority status:needs-review Awaiting code review type:chore Chore / small hygiene change type:documentation Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Child of #649] Audit: Issue Template Inventory & Standardization

1 participant