Skip to content

fix(desktop-integration): open control center via desktop id#773

Open
mhduiy wants to merge 1 commit into
linuxdeepin:masterfrom
mhduiy:active
Open

fix(desktop-integration): open control center via desktop id#773
mhduiy wants to merge 1 commit into
linuxdeepin:masterfrom
mhduiy:active

Conversation

@mhduiy

@mhduiy mhduiy commented Jun 12, 2026

Copy link
Copy Markdown
Contributor
  1. Replace D-Bus call to ControlCenter1 with launchByDesktopId
  2. Use desktop file ID "org.deepin.dde.control-center.desktop"
  3. Add qCInfo log for the open action

Log: Open control center via desktop file ID instead of D-Bus call

fix(desktop-integration): 通过 desktop id 打开控制中心

  1. 将 D-Bus 调用 ControlCenter1 替换为 launchByDesktopId
  2. 使用 desktop 文件 ID "org.deepin.dde.control-center.desktop"
  3. 添加 qCInfo 日志记录打开操作

Log: 通过 desktop 文件 ID 替代 D-Bus 调用打开控制中心
PMS: BUG-365867
Change-Id: I6442fe7f9df1adf275f13b2f6ec12b369608a7fb

Summary by Sourcery

Open system settings via desktop file ID instead of D-Bus

Bug Fixes:

  • Ensure system settings are opened using the desktop file ID rather than a direct D-Bus call

Enhancements:

  • Add informational logging when opening system settings via desktop integration

@sourcery-ai

sourcery-ai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replaces the previous D-Bus-based system settings opening mechanism with a desktop-file-based launcher and adds logging for the action.

Sequence diagram for opening system settings via desktop id

sequenceDiagram
    actor User
    participant DesktopIntegration
    participant Logger
    participant DesktopLauncher

    User->>DesktopIntegration: openSystemSettings()
    DesktopIntegration->>Logger: qCInfo(logDesktopIntegration)
    DesktopIntegration->>DesktopLauncher: launchByDesktopId(org.deepin.dde.control-center.desktop)
    DesktopLauncher-->>User: System settings window opened
Loading

File-Level Changes

Change Details Files
Switch system settings opening from D-Bus call to desktop ID launcher with logging.
  • Remove direct DDBusSender invocation targeting org.deepin.dde.ControlCenter1 and its Show method
  • Add qCInfo log statement indicating that system settings are being opened
  • Invoke launchByDesktopId with the org.deepin.dde.control-center.desktop desktop file ID
desktopintegration.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

1. Replace D-Bus call to ControlCenter1 with launchByDesktopId
2. Use desktop file ID "org.deepin.dde.control-center.desktop"
3. Add qCInfo log for the open action

Log: Open control center via desktop file ID instead of D-Bus call

fix(desktop-integration): 通过 desktop id 打开控制中心

1. 将 D-Bus 调用 ControlCenter1 替换为 launchByDesktopId
2. 使用 desktop 文件 ID "org.deepin.dde.control-center.desktop"
3. 添加 qCInfo 日志记录打开操作

Log: 通过 desktop 文件 ID 替代 D-Bus 调用打开控制中心
PMS: BUG-365867
Change-Id: I7b8c2588391227f2c746bb0551f7ebb62c2b4ef8

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider including the desktop ID in the log message (e.g., logging desktopId or the exact string) to make troubleshooting easier when multiple IDs might be used in the future.
  • If launchByDesktopId can fail or returns a status, it might be useful to handle or log failures so that issues opening the control center can be diagnosed more easily.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider including the desktop ID in the log message (e.g., logging `desktopId` or the exact string) to make troubleshooting easier when multiple IDs might be used in the future.
- If `launchByDesktopId` can fail or returns a status, it might be useful to handle or log failures so that issues opening the control center can be diagnosed more easily.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot

Copy link
Copy Markdown

@mhduiy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
github-pr-review-ci 3fc8856 link unknown /test github-pr-review-ci

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants