fix(desktop-integration): open control center via desktop id#773
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReplaces the previous D-Bus-based system settings opening mechanism with a desktop-file-based launcher and adds logging for the action. Sequence diagram for opening system settings via desktop idsequenceDiagram
actor User
participant DesktopIntegration
participant Logger
participant DesktopLauncher
User->>DesktopIntegration: openSystemSettings()
DesktopIntegration->>Logger: qCInfo(logDesktopIntegration)
DesktopIntegration->>DesktopLauncher: launchByDesktopId(org.deepin.dde.control-center.desktop)
DesktopLauncher-->>User: System settings window opened
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
1. Replace D-Bus call to ControlCenter1 with launchByDesktopId 2. Use desktop file ID "org.deepin.dde.control-center.desktop" 3. Add qCInfo log for the open action Log: Open control center via desktop file ID instead of D-Bus call fix(desktop-integration): 通过 desktop id 打开控制中心 1. 将 D-Bus 调用 ControlCenter1 替换为 launchByDesktopId 2. 使用 desktop 文件 ID "org.deepin.dde.control-center.desktop" 3. 添加 qCInfo 日志记录打开操作 Log: 通过 desktop 文件 ID 替代 D-Bus 调用打开控制中心 PMS: BUG-365867 Change-Id: I7b8c2588391227f2c746bb0551f7ebb62c2b4ef8
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider including the desktop ID in the log message (e.g., logging
desktopIdor the exact string) to make troubleshooting easier when multiple IDs might be used in the future. - If
launchByDesktopIdcan fail or returns a status, it might be useful to handle or log failures so that issues opening the control center can be diagnosed more easily.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider including the desktop ID in the log message (e.g., logging `desktopId` or the exact string) to make troubleshooting easier when multiple IDs might be used in the future.
- If `launchByDesktopId` can fail or returns a status, it might be useful to handle or log failures so that issues opening the control center can be diagnosed more easily.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@mhduiy: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Log: Open control center via desktop file ID instead of D-Bus call
fix(desktop-integration): 通过 desktop id 打开控制中心
Log: 通过 desktop 文件 ID 替代 D-Bus 调用打开控制中心
PMS: BUG-365867
Change-Id: I6442fe7f9df1adf275f13b2f6ec12b369608a7fb
Summary by Sourcery
Open system settings via desktop file ID instead of D-Bus
Bug Fixes:
Enhancements: