fix: fixed preexisting tests ci failure#5
Open
rohansen856 wants to merge 1 commit into
Open
Conversation
Signed-off-by: rohansen856 <rohansen856@gmail.com>
Member
Author
|
I also plan on looking into #4 (comment) in the same pr |
Contributor
|
@rohansen856 - I just got back from vacation - some more changes have been published to artifacts builder as it was decided to add distro in the naming as you correctly pointed out. Can you please pull the latest changes and update the testcases in the PR - I tried updating few but there exceptions - thx so much for your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two failing tests (
test_publish_with_rpm/test_publish_with_deb) were because of semantic drift: while PR #4 was open,maingained commits (1e27efd,e299ea6) that madeScriptBuilder.publish()stamp a distro suffix likeubuntu-22.04into every artifact name before upload, and that change had a bug wheredistro_detailsstayed at its hard-coded default when.distro_zab.txtwas missing. So in CI (which never creates that file), the tarball kept its original name but the RPM/DEB got uploaded astest-app-1.0.0-ubuntu-22.04-linux-s390x.{rpm,deb}, while the tests still asserted the old non-distro names, a mismatch that only surfaced once the PR was merged and CI ran against the combined code.