fix azure multilingual voice language SSML#5915
Open
mustafatarim wants to merge 1 commit into
Open
Conversation
a09c1af to
35294ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Azure TTS SSML generation for multilingual voices when the requested text language differs from the voice's primary locale.
Azure multilingual voices such as
en-US-JennyMultilingualNeuralcan synthesize other languages, but the generated SSML currently places the requested language only on the root<speak>element while the voice itself remains cross-locale. For cross-locale multilingual synthesis, this change wraps the spoken content in<lang xml:lang="...">and keeps the root language aligned with the voice locale.Changes
<lang xml:lang="...">only forMultilingualNeuralvoices whenlanguagediffers from the voice locale.Validation
uv run pytest tests/test_plugin_azure_tts.pyuv run ruff check livekit-plugins/livekit-plugins-azure/livekit/plugins/azure/tts.py tests/test_plugin_azure_tts.pyuv run ruff format --check livekit-plugins/livekit-plugins-azure/livekit/plugins/azure/tts.py tests/test_plugin_azure_tts.py