fix: aclose() blocks for close_timeout when child is externally killed#5930
Open
arpesenti wants to merge 7 commits into
Open
fix: aclose() blocks for close_timeout when child is externally killed#5930arpesenti wants to merge 7 commits into
arpesenti wants to merge 7 commits into
Conversation
arpesenti
force-pushed
the
fix-aclose-race-on-external-sigterm
branch
from
56954fc to
bf1c5bd
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5929
When the supervised process is killed by an external SIGTERM (e.g. process-group signal) before aclose() is called, the IPC channel is already closed. aclose() sends ShutdownRequest anyway (suppressed) then waits for ShutdownRequestAck via _shutdown_ack_fut. This future is resolved by _read_ipc_task when the channel closes, but that runs as a separate asyncio task — if the event loop hasn't processed it yet, aclose() blocks for the full close_timeout.
Fix: check is_alive() before sending ShutdownRequest. If the process is already dead, resolve both pending futures immediately.