fix: improve proxy SSL resilience under fragmented TCP delivery#20
Open
nik-localstack wants to merge 1 commit into
Open
fix: improve proxy SSL resilience under fragmented TCP delivery#20nik-localstack wants to merge 1 commit into
nik-localstack wants to merge 1 commit into
Conversation
bentsku
approved these changes
May 26, 2026
bentsku
left a comment
bentsku
left a comment
There was a problem hiding this comment.
LGTM, sounds like a good fix 👍 interesting how SSL is treated much differently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In container network environments (k3d, k8s), large TLS records can be split across multiple TCP segments. When the selector fires before the full record has arrived,
ssl.SSLSocket.recv()raisesssl.SSLWantReadError. BecauseSSLWantReadErroris a subclass of OSError, the proxy's read handler was incorrectly treating it as a peer disconnect, closing the SSL socket and causing clients to observe an SSLEOFError.Changes
add
except ssl.SSLWantReadError: passbeforeexcept OSErrorin theEVENT_READpath ofservice_connection.Tests
test_postgres_proxy_ssl_copy_batch_stress_regressionin localstack-pro (k8s pipeline) is reproducing the issue.