Allocate polyLocator as PointOnGeometryLocator[] for Android ART (#1192)#1215
Open
grootstebozewolf wants to merge 1 commit into
Open
Conversation
…ationtech#1192) A ternary of IndexedPointInAreaLocator[] vs SimplePointInAreaLocator[] is verified as Object[] by Android ART and fails dex2oat when assigned to PointOnGeometryLocator[]. Locators are created lazily in getLocator(), so allocating the declared interface array type is sufficient and safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dex2oatverification failure inRelatePointLocator.initwhen assigning a ternary of concrete locator arrays toPointOnGeometryLocator[](reported in Android dex2oatd error #1192).getLocator()with the prepared vs simple choice unchanged.Test plan
mvn -pl modules/core test -Dtest=RelatePointLocatorTest,RelateNGTest,RelateNGGCTest,RelateNGBoundaryNodeRuleTest,RelateNGRobustnessTest,RelatePredicateTest— 133 tests, 0 failuresdex2oatonRelatePointLocator(reporter environment if available)Fixes #1192