Fix stale snooze state in alarm list#678
Open
bjorkert wants to merge 1 commit into
Open
Conversation
The alarm list categorized snoozed vs. active alarms against Date() sampled at render time, but nothing re-rendered the view when a snooze expired. A lapsed snooze could stay in the Snoozed section for hours while the editor correctly showed it as not snoozed. Refresh a now snapshot on appear and on returning to the foreground, and drive all snooze comparisons through it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alarm list sorted alarms into Snoozed vs. Active by comparing
snoozedUntilagainstDate()at render time, but nothing re-rendered the view once a snooze expired. A lapsed snooze could sit in the Snoozed section for hours while the alarm editor correctly showed it as not snoozed.Refresh a
nowsnapshot ononAppearand when the app returns to the foreground, and route the snooze comparisons (both sections and the row label) through it.