Detect presence of DLight during initialization#10
Open
Xorlent wants to merge 9 commits into
Open
Conversation
|
I have a few M5 Atoms (S3R and Lite). Is it of interest for you to test since they are ESP32S3 based ? If yes, I will. |
Contributor
Author
|
Hi @leoaudebert-svg thank you for the offer. My biggest concern is the display code in the examples. If you have one of the example devices with a display to test, that would be a big help. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing Issue 7:
now returns aboolthat indicates whether the device acknowledged thePOWER_ON` command on the configured I2C address.true: a device acknowledged at the configured address, which is treated as sensor present.false: no device acknowledged at the configured address.Important
I do not have the M5Stack hardware needed to test and validate the updated examples. If someone with the hardware could kindly test and ensure they function properly prior to merging, I would appreciate it.