Skip to content

fix: enforce public board voting setting - #9506

Draft
Nameless-Monster-Nerd wants to merge 1 commit into
makeplane:previewfrom
Nameless-Monster-Nerd:codex/enforce-public-board-voting-setting
Draft

fix: enforce public board voting setting#9506
Nameless-Monster-Nerd wants to merge 1 commit into
makeplane:previewfrom
Nameless-Monster-Nerd:codex/enforce-public-board-voting-setting

Conversation

@Nameless-Monster-Nerd

Copy link
Copy Markdown

Description

Reject public-board vote creation when the board has voting disabled. This applies the same feature-flag enforcement already used by public comments and reactions, before any IssueVote is created.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Screenshots and Media (if applicable)

Not applicable; this is an API behavior fix.

Test Scenarios

  • pytest plane/tests/unit/views/test_issue_vote_public.py -vv
  • ruff check plane/space/views/issue.py plane/tests/unit/views/test_issue_vote_public.py
  • ruff format --check plane/space/views/issue.py plane/tests/unit/views/test_issue_vote_public.py

References

Closes #9500

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9ff3c327-8c07-4fcc-9727-ca5491b1b22a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Nazmus Samir seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(space): IssueVotePublicViewSet.create() does not enforce is_votes_enabled board setting

2 participants