fix(web): trailing slash on workspace notification list API - #9521
Open
misterkuka wants to merge 1 commit into
Open
fix(web): trailing slash on workspace notification list API#9521misterkuka wants to merge 1 commit into
misterkuka wants to merge 1 commit into
Conversation
list() omitted the trailing slash while every sibling method and the Django route require /users/notifications/. Self-hosted (Traefik) surfaces the upstream 404 as 500; unread badge still works. Fixes makeplane#9489
Open
1 task
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughBoth notification listing services now request trailing-slash endpoints. Existing pagination and response handling remain unchanged. ChangesNotification endpoint alignment
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sriramveeraghanta
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkspaceNotificationService.list()/fetchNotifications()called/users/notificationswithout a trailing slash..../users/notifications/(Django)..../unread/) worked; the inbox list 404'd (often surfaces as 500 behind Traefik on self-hosted).Changes
packages/services/src/workspace/notification.service.ts— append/onlist()apps/web/core/services/workspace-notification.service.ts— same forfetchNotifications()Fixes
Closes #9489
Test plan
GET /api/workspaces/{slug}/users/notifications/?…→ 200 withresultsNotes
Confirmed still present on v1.3.1, v1.4.0, and
previewHEAD before this change.Summary by CodeRabbit