fix(web): link active cycle progress empty state to cycle work items - #9527
fix(web): link active cycle progress empty state to cycle work items#9527reyrey112 wants to merge 1 commit into
Conversation
|
|
📝 WalkthroughWalkthroughThe active cycle progress card now links its heading and empty-state view to the active cycle’s project route. The route uses ChangesActive cycle navigation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/web/core/components/cycles/active-cycle/progress.tsx`:
- Around line 110-114: Add a single accessible name to the Link wrapping
SimpleEmptyState in the active-cycle progress empty state by applying the
translated title via aria-label, or mark the rendered image decorative with
alt="" for this linked context; ensure assistive technology does not announce
the title twice.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: d3ca0f86-a880-46ab-b17d-c3604aa539a5
📒 Files selected for processing (1)
apps/web/core/components/cycles/active-cycle/progress.tsx
| <Link href={`/${workspaceSlug}/projects/${projectId}/cycles/${cycle?.id}`}> | ||
| <div className="flex h-full w-full items-center justify-center"> | ||
| <SimpleEmptyState title={t("active_cycle.empty_state.progress.title")} assetPath={resolvedPath} /> | ||
| </div> | ||
| </Link> |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Give the empty-state link one accessible name.
SimpleEmptyState renders img alt={title} and <h3>{title}</h3>. Wrapping both in Link can cause assistive technology to announce the title twice. Add one translated aria-label to the link, or use alt="" for the decorative image in this linked state.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/web/core/components/cycles/active-cycle/progress.tsx` around lines 110 -
114, Add a single accessible name to the Link wrapping SimpleEmptyState in the
active-cycle progress empty state by applying the translated title via
aria-label, or mark the rendered image decorative with alt="" for this linked
context; ensure assistive technology does not announce the title twice.
2 participants
Description
Updated
apps/web/core/components/cycles/active-cycle/progress.tsxto make the cycle progress chart empty state link to the work items of that cycle.Wrapped h3 tag containing "Progress" chart title and div tag containing "SimpleEmptyState" with Link tag to cycle page.
Matches the current behavior of work item burndown chart in
apps/web/core/components/cycles/active-cycle/productivity.tsxType of Change
Files Changed
apps/web/core/components/cycles/active-cycle/progress.tsxSummary by CodeRabbit