telemetry: add ip-route and ip-pim-neighbor to default state-collect kinds#3827
Draft
ben-malbeclabs wants to merge 1 commit into
Draft
telemetry: add ip-route and ip-pim-neighbor to default state-collect kinds#3827ben-malbeclabs wants to merge 1 commit into
ben-malbeclabs wants to merge 1 commit into
Conversation
…kinds
Adds two kinds to the state-ingest server's default state-to-collect map:
- ip-route: show ip route vrf all
Exposes admin distance, programmed flags (hardwareProgrammed,
kernelProgrammed), routeAction, routeLeaked, directlyConnected — fields
the gNMI AFT path does not surface. Unblocks malbeclabs/infra#1410.
- ip-pim-neighbor: show ip pim neighbor
PIM neighbor adjacencies (state, hello-interval, expires, etc.) on
devices running PIM sparse-mode. Unblocks the per-multicast-group
dashboard's PIM neighbor health panel (malbeclabs/infra#1428).
Both are CLI-based state-collect rather than gNMI because:
- ip-route: gNMI AFT omits operationally critical fields (admin distance,
programmed flags).
- ip-pim-neighbor: OpenConfig PIM coverage in Arista's gNMI server is
limited and the existing multicast state-collect path (mroute, MSDP)
is the established pattern.
Per-command interval + device-pubkey targeting (infra#1409) is a separate
change. These two kinds initially run on the default cycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two CLI-based state-collect kinds to the state-ingest server's default
defaultStateToCollectShowCommandsmap:ip-route—show ip route vrf all. Exposes admin distance,hardwareProgrammed/kernelProgrammedflags,routeAction,routeLeaked,directlyConnected— fields the gNMI AFT path (/network-instances/.../afts/ipv4-unicast/ipv4-entry/*) does not surface. Unblocks the IP RIB ingest pipeline tracked in malbeclabs/infra#1410.ip-pim-neighbor—show ip pim neighbor. PIM sparse-mode neighbor adjacencies (state, hello-interval, expires). Unblocks the multicast operator dashboard's PIM neighbor health panel (Part B of malbeclabs/infra#1428).Why state-collect rather than gNMI
ip-route: gNMI AFT omits the operationally first-class fields (admin distance, programmed flags). CLI JSON gives all of them at the cost of one snapshot per cycle. Same trade-off captured in infra#1410.ip-pim-neighbor: OpenConfig PIM coverage in Arista's gNMI server is limited; the existing DZ multicast state-collect path (mroute, MSDP) is the established pattern.Scope notes
ip-routeandip-pim-neighborare both lightweight per-device snapshots.Testing Verification
TestTelemetry_StateIngest_Handler_StateToCollect_UsesDefaultShowCommandsAndCustomto assert the 9 expected default kinds (was 7), including the two new ones, and the unchangedbgp-socketscustom.go test ./telemetry/state-ingest/...green.