Skip to content

#10 allow custom implementation names#27

Merged
filiphr merged 2 commits into
mapstruct:mainfrom
hduelme:allow-custom-implementation-names
May 31, 2026
Merged

#10 allow custom implementation names#27
filiphr merged 2 commits into
mapstruct:mainfrom
hduelme:allow-custom-implementation-names

Conversation

@hduelme
Copy link
Copy Markdown
Contributor

@hduelme hduelme commented May 31, 2026

Fixes #10 by allowing custom implementation names.
The implementation is inspired by @Mapper from MapStruct.

@hduelme hduelme force-pushed the allow-custom-implementation-names branch from d729700 to d54d070 Compare May 31, 2026 12:37
Copy link
Copy Markdown
Member

@filiphr filiphr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @hduelme. I've left some comments

Comment thread api/src/main/java/org/mapstruct/tools/gem/GemDefinition.java Outdated
Comment thread api/src/main/java/org/mapstruct/tools/gem/GemDefinition.java Outdated
Comment thread api/src/main/java/org/mapstruct/tools/gem/GemDefinition.java Outdated
@hduelme hduelme force-pushed the allow-custom-implementation-names branch from 562a3d2 to 1aaf647 Compare May 31, 2026 15:34
@hduelme
Copy link
Copy Markdown
Contributor Author

hduelme commented May 31, 2026

@filiphr thanks for the fast review.
I fixed your findings.

@filiphr filiphr merged commit cd166c7 into mapstruct:main May 31, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate file created when using multiple annotations with the same name

2 participants