Skip to content

generalize continuous_comp_cvg - #2082

Merged
affeldt-aist merged 3 commits into
math-comp:masterfrom
t6s:continuous_comp_cvg20260815
Aug 16, 2026
Merged

generalize continuous_comp_cvg#2082
affeldt-aist merged 3 commits into
math-comp:masterfrom
t6s:continuous_comp_cvg20260815

Conversation

@t6s

@t6s t6s commented Aug 15, 2026

Copy link
Copy Markdown
Member
Motivation for this change

This PR is a strict generalization of lemma continuous_comp_cvg that has been in pseudometric_structure.v pseudometric_normed_Zmodule.v.

NB: the name continuous_comp_cvg does not look very good considering similar lemmas continuous_cvg and cvg_comp.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md

- [ ] added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@t6s t6s changed the title generalize continuou_comp_cvg generalize continuous_comp_cvg Aug 15, 2026
@t6s
t6s requested a review from affeldt-aist August 15, 2026 13:36

@affeldt-aist affeldt-aist left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the generalization! Let's add id_continuous because incidentally we also needed the lemma in another piece of work (and I also remember this was due some performance problem but maybe not a Search).

@affeldt-aist affeldt-aist added this to the 1.18.0 milestone Aug 16, 2026
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Aug 16, 2026
@affeldt-aist
affeldt-aist merged commit c016f6e into math-comp:master Aug 16, 2026
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants