Skip to content

DEV-20451: sync system-test fixtures for accurate time-spent metric #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
caddoo wants to merge 14 commits into
base: prepare6x
Choose a base branch
from
Draft

DEV-20451: sync system-test fixtures for accurate time-spent metric #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
eb695a4
Adapt Vue sources to the Vite build and rebuild dist for Matomo 6
sgiehl Jun 19, 2026
8ea2860
Rebuild Vue dist files for Vue 3.5
sgiehl Jun 19, 2026
a9bea1c
DEV-20451: sync system-test fixtures for accurate time-spent metric
caddoo Jul 9, 2026
5882524
DEV-20451: refresh fixtures after removing nb_hits_with_time_spent
caddoo Jul 16, 2026
d08286e
Merge commit '8ea2860' into DEV-20451
caddoo Jul 16, 2026
b7f059a
Merge remote-tracking branch 'origin/prepare6x' into DEV-20451
caddoo Jul 17, 2026
467e4e1
Merge remote-tracking branch 'origin/prepare6x' into DEV-20451
caddoo Jul 21, 2026
9aaf1f1
Update expected UI screenshots for the new headless Chrome (Node 24 /…
sgiehl Jun 22, 2026
77c5b90
DEV-20451: sync AutoSuggestAPITest fixture for accurate per-pageview …
caddoo Jul 22, 2026
edbc59c
Drop the array custom-variable name from the tracking fixture
sgiehl Jul 24, 2026
21f3011
Recover the malformed-custom-variable coverage via direct cvar injection
sgiehl Jul 27, 2026
8dfb104
Merge commit '9aaf1f17d32308e0f02e41aa365167314b52a75e' into DEV-20451
tzi Jul 27, 2026
2d8edfe
Merge commit '839c3c7e02a52cf7a2665b58ed75c0ccc5b18d8c' into DEV-20451
tzi Jul 27, 2026
25e0375
Merge 6.x-dev submodule pin into DEV-20451
caddoo Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/Fixtures/TwoVisitsWithCustomVariables.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,10 @@ private function trackVisits()
$visitorB->setCustomVariable($id = 2, $name = 'Othercustom value which should be truncated abcdefghijklmnopqrstuvwxyz', $value = 'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz');
$visitorB->setCustomVariable($id = -2, $name = 'not tracked', $value = 'not tracked');
$visitorB->setCustomVariable($id = 6, $name = 'not tracked', $value = 'not tracked');
$visitorB->setCustomVariable($id = 6, $name = array('not tracked'), $value = 'not tracked');
// A custom variable with a non-string (array) name can no longer go through the
// type-safe setCustomVariable(); inject it straight into the cvar payload so we
// still verify a malformed custom variable is not tracked.
$visitorB->visitorCustomVar[6] = array(array('not tracked'), 'not tracked');
$visitorB->setUrl('http://example.org/homepage');
self::checkResponse($visitorB->doTrackGoal($idGoal, 1000));

Expand Down
68 changes: 34 additions & 34 deletions tests/System/expected/test_AutoSuggestAPITest__Live.getLastVisitsDetails_range.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,8 @@

<pageId>46</pageId>
<bandwidth />
<timeSpent>1621</timeSpent>
<timeSpentPretty>27 min 1s</timeSpentPretty>
<timeSpent>360</timeSpent>
<timeSpentPretty>6 min 0s</timeSpentPretty>
<pageviewPosition>1</pageviewPosition>
<title>Space Quest XII</title>
<subtitle>http://piwik.net/space/quest/iv</subtitle>
Expand Down Expand Up @@ -556,8 +556,8 @@

<pageId>41</pageId>
<bandwidth />
<timeSpent>1621</timeSpent>
<timeSpentPretty>27 min 1s</timeSpentPretty>
<timeSpent>1620</timeSpent>
<timeSpentPretty>27 min 0s</timeSpentPretty>
<pageviewPosition>1</pageviewPosition>
<title>Space Quest XII</title>
<subtitle>http://piwik.net/space/quest/iv</subtitle>
Expand Down Expand Up @@ -945,8 +945,8 @@

<pageId>35</pageId>
<bandwidth />
<timeSpent>1623</timeSpent>
<timeSpentPretty>27 min 3s</timeSpentPretty>
<timeSpent>360</timeSpent>
<timeSpentPretty>6 min 0s</timeSpentPretty>
<pageviewPosition>1</pageviewPosition>
<title>Space Quest XII</title>
<subtitle>http://piwik.net/space/quest/iv</subtitle>
Expand Down Expand Up @@ -1376,8 +1376,8 @@

<pageId>30</pageId>
<bandwidth />
<timeSpent>1621</timeSpent>
<timeSpentPretty>27 min 1s</timeSpentPretty>
<timeSpent>1620</timeSpent>
<timeSpentPretty>27 min 0s</timeSpentPretty>
<pageviewPosition>1</pageviewPosition>
<title>Space Quest XII</title>
<subtitle>http://piwik.net/space/quest/iv</subtitle>
Expand Down Expand Up @@ -1756,8 +1756,8 @@

<pageId>24</pageId>
<bandwidth />
<timeSpent>1621</timeSpent>
<timeSpentPretty>27 min 1s</timeSpentPretty>
<timeSpent>360</timeSpent>
<timeSpentPretty>6 min 0s</timeSpentPretty>
<pageviewPosition>1</pageviewPosition>
<title>Space Quest XII</title>
<subtitle>http://piwik.net/space/quest/iv</subtitle>
Expand Down Expand Up @@ -2164,8 +2164,8 @@

<pageId>80</pageId>
<bandwidth />
<timeSpent>1623</timeSpent>
<timeSpentPretty>27 min 3s</timeSpentPretty>
<timeSpent>1620</timeSpent>
<timeSpentPretty>27 min 0s</timeSpentPretty>
<pageviewPosition>1</pageviewPosition>
<title>Space Quest XII</title>
<subtitle>http://piwik.net/space/quest/iv</subtitle>
Expand Down Expand Up @@ -2409,8 +2409,8 @@

<pageId>19</pageId>
<bandwidth />
<timeSpent>1623</timeSpent>
<timeSpentPretty>27 min 3s</timeSpentPretty>
<timeSpent>1620</timeSpent>
<timeSpentPretty>27 min 0s</timeSpentPretty>
<pageviewPosition>1</pageviewPosition>
<title>Space Quest XII</title>
<subtitle>http://piwik.net/space/quest/iv</subtitle>
Expand Down Expand Up @@ -2980,8 +2980,8 @@

<pageId>74</pageId>
<bandwidth />
<timeSpent>1621</timeSpent>
<timeSpentPretty>27 min 1s</timeSpentPretty>
<timeSpent>360</timeSpent>
<timeSpentPretty>6 min 0s</timeSpentPretty>
<pageviewPosition>1</pageviewPosition>
<title>Space Quest XII</title>
<subtitle>http://piwik.net/space/quest/iv</subtitle>
Expand Down Expand Up @@ -3212,8 +3212,8 @@

<pageId>13</pageId>
<bandwidth />
<timeSpent>1621</timeSpent>
<timeSpentPretty>27 min 1s</timeSpentPretty>
<timeSpent>360</timeSpent>
<timeSpentPretty>6 min 0s</timeSpentPretty>
<pageviewPosition>1</pageviewPosition>
<title>Space Quest XII</title>
<subtitle>http://piwik.net/space/quest/iv</subtitle>
Expand Down Expand Up @@ -3770,8 +3770,8 @@

<pageId>91</pageId>
<bandwidth />
<timeSpent>1621</timeSpent>
<timeSpentPretty>27 min 1s</timeSpentPretty>
<timeSpent>1620</timeSpent>
<timeSpentPretty>27 min 0s</timeSpentPretty>
<pageviewPosition>1</pageviewPosition>
<title>Space Quest XII</title>
<subtitle>http://piwik.net/space/quest/iv</subtitle>
Expand Down Expand Up @@ -3991,8 +3991,8 @@

<pageId>69</pageId>
<bandwidth />
<timeSpent>1621</timeSpent>
<timeSpentPretty>27 min 1s</timeSpentPretty>
<timeSpent>1620</timeSpent>
<timeSpentPretty>27 min 0s</timeSpentPretty>
<pageviewPosition>1</pageviewPosition>
<title>Space Quest XII</title>
<subtitle>http://piwik.net/space/quest/iv</subtitle>
Expand Down Expand Up @@ -4204,8 +4204,8 @@

<pageId>58</pageId>
<bandwidth />
<timeSpent>1621</timeSpent>
<timeSpentPretty>27 min 1s</timeSpentPretty>
<timeSpent>1620</timeSpent>
<timeSpentPretty>27 min 0s</timeSpentPretty>
<pageviewPosition>1</pageviewPosition>
<title>Space Quest XII</title>
<subtitle>http://piwik.net/space/quest/iv</subtitle>
Expand Down Expand Up @@ -4425,8 +4425,8 @@

<pageId>8</pageId>
<bandwidth />
<timeSpent>1621</timeSpent>
<timeSpentPretty>27 min 1s</timeSpentPretty>
<timeSpent>1620</timeSpent>
<timeSpentPretty>27 min 0s</timeSpentPretty>
<pageviewPosition>1</pageviewPosition>
<title>Space Quest XII</title>
<subtitle>http://piwik.net/space/quest/iv</subtitle>
Expand Down Expand Up @@ -5318,8 +5318,8 @@

<pageId>85</pageId>
<bandwidth />
<timeSpent>1623</timeSpent>
<timeSpentPretty>27 min 3s</timeSpentPretty>
<timeSpent>360</timeSpent>
<timeSpentPretty>6 min 0s</timeSpentPretty>
<pageviewPosition>1</pageviewPosition>
<title>Space Quest XII</title>
<subtitle>http://piwik.net/space/quest/iv</subtitle>
Expand Down Expand Up @@ -5590,8 +5590,8 @@

<pageId>63</pageId>
<bandwidth />
<timeSpent>1623</timeSpent>
<timeSpentPretty>27 min 3s</timeSpentPretty>
<timeSpent>360</timeSpent>
<timeSpentPretty>6 min 0s</timeSpentPretty>
<pageviewPosition>1</pageviewPosition>
<title>Space Quest XII</title>
<subtitle>http://piwik.net/space/quest/iv</subtitle>
Expand Down Expand Up @@ -5854,8 +5854,8 @@

<pageId>52</pageId>
<bandwidth />
<timeSpent>1623</timeSpent>
<timeSpentPretty>27 min 3s</timeSpentPretty>
<timeSpent>360</timeSpent>
<timeSpentPretty>6 min 0s</timeSpentPretty>
<pageviewPosition>1</pageviewPosition>
<title>Space Quest XII</title>
<subtitle>http://piwik.net/space/quest/iv</subtitle>
Expand Down Expand Up @@ -6126,8 +6126,8 @@

<pageId>2</pageId>
<bandwidth />
<timeSpent>1623</timeSpent>
<timeSpentPretty>27 min 3s</timeSpentPretty>
<timeSpent>360</timeSpent>
<timeSpentPretty>6 min 0s</timeSpentPretty>
<pageviewPosition>1</pageviewPosition>
<title>Space Quest XII</title>
<subtitle>http://piwik.net/space/quest/iv</subtitle>
Expand Down
Loading