Remove the unminified Vue UMD bundle - #140
Merged
Merged
Conversation
Matomo's Vue build no longer emits <Plugin>.umd.js. Only the minified CustomVariables.umd.min.js is ever served: PluginUmdAssetFetcher looks exclusively for .umd.min.js, and development mode uses the .development.umd.js produced by vue:build --watch. The unminified bundle was a leftover from Vue CLI, whose lib build emitted it alongside the minified one for free. See matomo-org/matomo#25027.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the unminified
<Plugin>.umd.jsVue bundle, which is no longer built, and adds a.gitignoreentry so it does not come back.Matomo's Vue build used to run two full Vite passes per plugin, emitting an unminified
<Plugin>.umd.jsnext to<Plugin>.umd.min.js. Only the minified bundle is ever served:PluginUmdAssetFetcher::getUmdFileToUseForPlugin()andgetAllPluginUmds()look exclusively for.umd.min.js..development.umd.js, produced byvue:build --watchand already gitignored.The unminified pass was a leftover from Vue CLI, whose
--target libbuild emitted.common.js,.umd.jsand.umd.min.jsin one go..common.jswas gitignored away long ago;.umd.jssurvived only because it came for free.Core change: matomo-org/matomo#25027. Once that lands, this file is no longer regenerated by
vue:build.Notes for review
.umd.js, and.umd.min.jsis untouched, so this is safe to merge before or after the core PR..gitignorepattern*.umd.jsdoes not match*.umd.min.js.Checklist