Skip to content

Document DCR redirect URI allowlist wildcard and query matching behavior#9065

Open
pvev wants to merge 1 commit into
masterfrom
MM-69392-dcr-uri-fix
Open

Document DCR redirect URI allowlist wildcard and query matching behavior#9065
pvev wants to merge 1 commit into
masterfrom
MM-69392-dcr-uri-fix

Conversation

@pvev

@pvev pvev commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Documents the OAuth Dynamic Client Registration (DCR) redirect URI allowlist matching behavior the * and ** wildcards, per-URL-component matching, and the rule that query strings match only when a pattern explicitly includes one — so admins know how to write patterns and how to allow query-bearing redirect URIs.

Ticket Link

https://mattermost.atlassian.net/browse/MM-69392

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c5bf185e-37e7-4559-86c5-84fcfa6505d1

📥 Commits

Reviewing files that changed from the base of the PR and between 2b08f6f and 0246b8c.

📒 Files selected for processing (1)
  • source/administration-guide/configure/integrations-configuration-settings.rst

📝 Walkthrough

Walkthrough

Nine lines of documentation are added to integrations-configuration-settings.rst under the DCR redirect URI allowlist section, describing how URI matching works: per-component matching, wildcard semantics (* vs **), restrictions on cross-component wildcard use, and query string matching requirements.

Changes

DCR Redirect URI Allowlist Documentation

Layer / File(s) Summary
Redirect URI matching rules
source/administration-guide/configure/integrations-configuration-settings.rst
Adds documentation specifying per-URL-component matching, wildcard semantics (* matches anything except /, ** includes /), component-local wildcard constraints, and query string matching behaviour including guidance for permitting both query and non-query redirect URIs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main documentation change about DCR redirect URI allowlist wildcard and query matching behaviour.
Description check ✅ Passed The description matches the documented DCR redirect URI allowlist matching behaviour and is clearly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch MM-69392-dcr-uri-fix

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Newest code from mattermost has been published to preview environment for Git SHA 0246b8c

@edgarbellot edgarbellot self-requested a review June 26, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants