Add #252 to changelog#253
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe 1.14.0 changelog entry now documents replacing ChangesPHP 8.6 compatibility documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the CHANGELOG.md to document the replacement of XtOffsetOf() with offsetof() due to the removal of the XtOffsetOf() alias in PHP 8.6. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
Updates the project changelog to document the change introduced in GitHub issue/PR #252, keeping release notes current for the next version.
Changes:
- Added a new 1.14.0 changelog bullet noting the replacement of
XtOffsetOf()withoffsetof()due to PHP 8.6 changes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * Replaced XtOffsetOf() with offsetof(). The XtOffsetOf() alias has been | ||
| removed in PHP 8.6. Pull request by Remi Collet. GitHub #252. |
Summary by CodeRabbit
XtOffsetOf()withoffsetof().XtOffsetOf()alias is removed in PHP 8.6.