Skip to content

Add #252 to changelog#253

Merged
oschwald merged 1 commit into
mainfrom
wstorey/changelog
Jul 17, 2026
Merged

Add #252 to changelog#253
oschwald merged 1 commit into
mainfrom
wstorey/changelog

Conversation

@horgh

@horgh horgh commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Documentation
    • Updated the 1.14.0 changelog to reflect replacement of XtOffsetOf() with offsetof().
    • Noted that the XtOffsetOf() alias is removed in PHP 8.6.

Copilot AI review requested due to automatic review settings July 17, 2026 15:16
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 710146b7-a92a-4bd3-b672-ef6b628d7380

📥 Commits

Reviewing files that changed from the base of the PR and between 6d613ac and f65c6a3.

📒 Files selected for processing (1)
  • CHANGELOG.md

📝 Walkthrough

Walkthrough

The 1.14.0 changelog entry now documents replacing XtOffsetOf() with offsetof() and the alias removal in PHP 8.6.

Changes

PHP 8.6 compatibility documentation

Layer / File(s) Summary
Update 1.14.0 release note
CHANGELOG.md
The changelog identifies offsetof() as the replacement and notes removal of the XtOffsetOf() alias in PHP 8.6.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Poem

A rabbit hops through changelog lines,
Where offsetof() neatly shines.
Old aliases fade with PHP’s tide,
New release notes stand beside.
Nibble, hop, and ship with pride!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is related to the only change, a changelog update, though it is less specific than the actual content.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch wstorey/changelog

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CHANGELOG.md to document the replacement of XtOffsetOf() with offsetof() due to the removal of the XtOffsetOf() alias in PHP 8.6. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project changelog to document the change introduced in GitHub issue/PR #252, keeping release notes current for the next version.

Changes:

  • Added a new 1.14.0 changelog bullet noting the replacement of XtOffsetOf() with offsetof() due to PHP 8.6 changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CHANGELOG.md Outdated
Comment on lines +11 to +12
* Replaced XtOffsetOf() with offsetof(). The XtOffsetOf() alias has been
removed in PHP 8.6. Pull request by Remi Collet. GitHub #252.
@horgh
horgh force-pushed the wstorey/changelog branch from 6d613ac to f65c6a3 Compare July 17, 2026 15:22
@oschwald
oschwald merged commit 4e9ccee into main Jul 17, 2026
86 checks passed
@oschwald
oschwald deleted the wstorey/changelog branch July 17, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants