Add residential proxy data to Anonymizer#433
Conversation
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for the new Residential property on the Anonymizer response model, which contains data from the full-feed GeoIP Residential Proxy database. The changes include updating test response JSON files, adding unit tests to verify the serialization and behavior of the new property (including a test case for when only the residential sub-object is present), and updating the release notes for version 6.1.0. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
aa3389a to
0321b11
Compare
Surface the new Residential sub-object on the anonymizer object in the Insights and Factors response models. This is inherited directly from MaxMind.GeoIP2.Model.Anonymizer via MaxMind.MinFraud.Response.IPAddress, which extends MaxMind.GeoIP2.Responses.InsightsResponse, so no new model code is needed here. Test data and tests are updated to cover the new residential field, including the case where the anonymizer object contains only the residential sub-object. Requires MaxMind.GeoIP2 6.1.0 or greater at release time; the dependency in MaxMind.MinFraud.csproj is left unchanged for now since 6.1.0 has not been released. STF-997 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
0321b11 to
4bf97e5
Compare
|
Claude, on behalf of Greg: This PR was inadvertently closed by a head-branch rename (the branch now references the release ticket). Superseded by #434, which carries the identical commit. |
1 participant
Summary
Surfaces the new
residentialsub-object of theanonymizerobject in the minFraud Insights and Factorsip_addressresponse. The models reuse the GeoIP2 library's Anonymizer record, so this is a fixtures/tests/changelog change; the field flows through via the dependency.Depends on maxmind/GeoIP2-dotnet#494. At release time the
MaxMind.GeoIP2PackageReference must be bumped to 6.1.0 once published.Testing
With GeoIP2 packed from that PR (local NuGet source, not committed): dotnet build clean on all five target frameworks; 181/181 tests pass on net8.0/net9.0/net10.0.
🤖 Generated with Claude Code