Update wiki installation instructions for animate build requirements#178
Merged
Conversation
joewallwork
reviewed
Jun 15, 2026
| git submodule init | ||
| git submodule update | ||
| pip uninstall ${REPO_NAME} -y || true | ||
| [ -f ${REPO_NAME}/requirements-build.txt ] && pip install -r ${REPO_NAME}/requirements-build.txt |
Member
There was a problem hiding this comment.
I don't recognise this syntax - what does the first bit do?
Member
Author
There was a problem hiding this comment.
One of the many ways to test for the existence of a file (only animate has this file) - changed to something more intuitive now. Could have done pip instal ... || true as well, but wanted to make sure it fails if the install fails.
Also add pip install -r requirements-build.txt step to reusable test suite. At the moment, this is not strictly needed because the requirements should have been installed during the build of the container, but if in a PR we change the build requirements, we do want to test this step.
stephankramer
force-pushed
the
skramer/animate-build-requirements
branch
from
6d43c00 to
15978da
Compare
joewallwork
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add pip install -r requirements-build.txt step to reusable test suite. At the moment, this is not strictly needed because the requirements should have been installed during the build of the container, but if in a PR we change the build requirements, we do want to test this step.