Add room to machine and switch#156
Open
majst01 wants to merge 1 commit into
Open
Conversation
2 tasks
mwennrich
approved these changes
Jul 14, 2026
mwennrich
approved these changes
Jul 14, 2026
majst01
force-pushed
the
add-room-to-machine-and-switch
branch
from
4336cf9 to
96186f6
Compare
Gerrit91
added
the
requires docs update
Contributor
|
The room concept needs to be reflected in our official documentation describing what this is specifically used for, when it is optional and what effects it has if any. Here is the ongoing PR for this: metal-stack/website#278 |
majst01
force-pushed
the
add-room-to-machine-and-switch
branch
from
96186f6 to
5c397a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Retrofit metal-stack/metal-api#651
Intentionally break proto by re-using indices in favour of nice and aligned messages.
This is probably the last time such breaking changes can be made.
Bycatch was the removal of unnecessary package in the auditing annotation in the api package
Used AI-Tools ✨