Add admin status to nic port#655
Draft
iljarotar wants to merge 10 commits into
Draft
Conversation
metal-robot
Bot
added
the
area: control-plane
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The double-role of the
Actualfield of a switch port causes a bug in the metal-core that sometimes results in ports being set to DOWN by metal-core (metal-stack/metal-core#196).A cleaner solution would include adding a table for the switch status and remove all status fields from the switch table. Then the reports coming from metal-core will only be reflected in the switch status table while the switch table would only hold the desired state of a switch. Once metal-core is migrated to v2API, we should work on this cleaner solution. For now, this quick solution is okay, I think.
TODO