[Subscription Billing] Page 8002 "Extend Contract" — move key variables to protected var and add setters for PageExtension automation#9715
Open
pamura1977 wants to merge 1 commit into
Conversation
…geExtension automation Fixes issue microsoft#8856: - Move CustomerContractNo, VendorContractNo, SubscriptionDescription, ItemDescription, UnitPrice, UnitCostLCY, ProvisionStartDate from global var to protected var - Add SetVendorContractParameters() and SetItemParameters() following the existing SetUsageBasedParameters() pattern - Extend SetGlobalsFromParameters() with the corresponding assignments - Preserve programmatically supplied VariantCode after ValidateItemNo() resets it
github-actions
Bot
added
AL: Apps (W1)
Author
|
@microsoft-github-policy-service agree company="redPoint AG" |
github-actions
Bot
added
the
needs-approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Page 8002 "Extend Contract" only exposed a limited set of variables in its
protected varsection, leaving several variables that partner extensions need to read or write in the global (unprotected)varblock. This blocked automation scenarios on top of the standard "Extend Contract" flow without cloning the entire page.This change moves seven variables (
CustomerContractNo,VendorContractNo,SubscriptionDescription,ItemDescription,UnitPrice,UnitCostLCY,ProvisionStartDate) toprotected var, and adds two new setter procedures (SetVendorContractParameters(),SetItemParameters()) following the existingSetUsageBasedParameters()pattern, so that a PageExtension can supply these values beforeOnOpenPageruns its validation chain, ensuring dependent fields (item description, unit price/cost, subscription packages) are populated correctly instead of appearing empty.Linked work
Fixes #8856
How I validated this
What I tested and the outcome
Risk & compatibility
None expected. All changes are additive:
vartoprotected vardoes not change any existing behavior for the base app or existing callers. It only widens accessibility for PageExtensions.VariantCodeParamat the end ofOnOpenPage) is guarded byif VariantCodeParam <> '', so existing manual-entry behavior (no parameters supplied) is unchanged.