Skip to content

Fix nightly macOS clippy-features job by removing stale workspace feature#1129

Closed
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-clippy-features-macos-again
Closed

Fix nightly macOS clippy-features job by removing stale workspace feature#1129
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-clippy-features-macos-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jun 3, 2026

The nightly clippy-features (macos) job was failing because the workflow passed bf_tree in --features, but no selected workspace package exposes that feature. This PR removes the stale feature from the nightly feature set so clippy can run against valid workspace features.

  • Root cause

    • .github/workflows/nightly.yml defined DISKANN_FEATURES with bf_tree, which is not a valid workspace feature name for the clippy workspace invocation.
  • Change

    • Updated the nightly workflow environment feature list to remove bf_tree and keep only valid features used by the workspace clippy/test jobs.
  • Patch excerpt

    # .github/workflows/nightly.yml
    DISKANN_FEATURES: "virtual_storage,spherical-quantization,product-quantization,tracing,experimental_diversity_search,disk-index,flatbuffers,linalg,codegen"

Copilot AI changed the title [WIP] Fix failing GitHub Actions job clippy-features (macos) Fix nightly macOS clippy-features job by removing stale workspace feature Jun 3, 2026
Copilot AI requested a review from arrayka June 3, 2026 05:43
@arrayka
Copy link
Copy Markdown
Contributor

arrayka commented Jun 3, 2026

It's a duplicate of #1112

@arrayka arrayka closed this Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants