Installer: replace confusing mount prompt with radio dialog#2012
Open
tyrielv wants to merge 1 commit into
Open
Installer: replace confusing mount prompt with radio dialog#2012tyrielv wants to merge 1 commit into
tyrielv wants to merge 1 commit into
Conversation
The Yes/No/Cancel MsgBox shown when mounted repos are detected during
install was confusing -- the Yes option meant "keep repos mounted"
(the less-common, advanced staging case), which inverted user
expectations and required reading the message body carefully to map
button semantics to outcomes.
Replace it with a custom modal containing two radio buttons and
Continue/Cancel:
(*) Remount repos as part of the installation
They will be temporarily unavailable.
( ) Keep repos mounted
The upgrade will complete automatically when all repos are
unmounted, or at next reboot.
The remount option is selected by default, matching the previous IDYES
default's intent (proceed with the common path).
Silent-mode STAGEIFMOUNTED=true|false behavior is unchanged.
Assisted-by: Claude Opus 4.7
Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Yes/No/Cancel prompt shown by
Setup.isswhen mounted repos are detected during install is confusing — the Yes button means "keep repos mounted" (the less-common, advanced staging case), which inverts user expectations and requires reading the message body carefully to map button semantics to outcomes.This PR replaces the
MsgBox(MB_YESNOCANCEL)with a custom modal containing two radio buttons and Continue / Cancel.Before
After
Behavior
{app}\PendingUpgrade\and completes automatically once all repos unmount or at next reboot. Equivalent to the previous Yes answer.Installation cancelled.Equivalent to the previous Cancel.Silent-mode behavior is unchanged:
STAGEIFMOUNTED=true|falseis still honored whenWizardSilent()is true.Testing
SetupGVFS.0.2.26160.18467.exelocally and confirmed the new dialog renders correctly with two mounted repos.Notes
TForm(Delphi base class), notTSetupForm, becauseTSetupFormrequires a registered DFM resource that fails to load at runtime in Pascal script context.pr-assetsbranch in the fork so binary assets do not bloat the main repository history.