test(cli): quarantine ResourceCommand_FailsWhenInteractionServiceIsRequired (#17485)#17486
Open
mitchdenny wants to merge 1 commit into
Open
test(cli): quarantine ResourceCommand_FailsWhenInteractionServiceIsRequired (#17485)#17486mitchdenny wants to merge 1 commit into
mitchdenny wants to merge 1 commit into
Conversation
This E2E test is intermittently failing when 'aspire stop' is invoked immediately after a deliberately-failing resource command. The CLI prints 'Failed to stop apphost.cs' and the DCP-managed redis container is still running at the moment of failure, indicating that ProcessShutdownService.StopProcessesAsync exhausts its graceful + force-kill + monitor budget before DCP finishes the container teardown under Docker-in-Docker contention on the ubuntu-latest runner. Quarantine while investigation of the underlying shutdown-timing behavior continues. - Quarantined: Aspire.Cli.EndToEnd.Tests.ResourceCommandTests.ResourceCommand_FailsWhenInteractionServiceIsRequired - Issue: #17485 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mitchdenny
added
flaky-test
area-cli
quarantined-test
8 tasks
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17486Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17486" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR quarantines a single flaky Aspire CLI E2E test (ResourceCommand_FailsWhenInteractionServiceIsRequired) by adding a [QuarantinedTest] trait with a link to the tracking issue (#17485). This aligns with the repository’s existing quarantine mechanism (Aspire.TestUtilities.QuarantinedTestAttribute) used to sequester unstable tests without changing production behavior.
Changes:
- Added
[QuarantinedTest("https://github.com/microsoft/aspire/issues/17485")]toResourceCommand_FailsWhenInteractionServiceIsRequired. - Added
using Aspire.TestUtilities;to support the quarantine attribute.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.Cli.EndToEnd.Tests/ResourceCommandTests.cs | Marks the flaky E2E test as quarantined via Aspire.TestUtilities.QuarantinedTestAttribute (issue-linked). |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
Contributor
|
❌ CLI E2E Tests failed — 93 passed, 1 failed, 6 unknown (commit Failed Tests
View all recordings
📹 Recordings uploaded automatically from CI run #26430255552 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Quarantines
Aspire.Cli.EndToEnd.Tests.ResourceCommandTests.ResourceCommand_FailsWhenInteractionServiceIsRequiredwhile we investigate the underlying shutdown-timing issue tracked by #17485.Why now
The test was observed flaking on PR #17452 (run 26425521402) — attempts 1 and 3 failed, attempt 2 passed — even though that PR only touches CLI init/channel/scaffolding code paths and has no plausible causal link to
aspire stop,ProcessShutdownService, the auxiliary backchannel, or DCP container shutdown.What's actually broken
The Hex1b automator times out on
WaitUntilText(" stopped successfully."), but the cast file showsaspire stopactively prints:after spinning for ~60s. At the moment of failure, the post-step
docker container lsin the same CI job shows the redis container still running:ProcessShutdownService.StopProcessesAsync(10s graceful → force-kill → monitor) is exhausting its budget while DCP is still tearing down the container under Docker-in-Docker contention onubuntu-latest. Issue #17485 captures the suspected root cause and the speculative follow-up of extending the shutdown monitor window for DCP-managed-container scenarios.Change
Adds
[QuarantinedTest("https://github.com/microsoft/aspire/issues/17485")]to the single affected test method viatools/QuarantineTools. No production code changes.Checklist
Addresses #17485. Related PR where the failure was observed: #17452.