Follow up: isolate per-operation cancellation state - #998
Draft
bmehta001 wants to merge 1 commit into
Draft
Conversation
Give each inference invocation a stable cancellation identity so queued, running, and completed requests cannot cancel one another or outlive their session state. Isolate deadlines and generators per operation, make model/session ownership teardown-safe, and preserve legacy synchronous cancellation behavior while enabling the upcoming operation ABI.
Files changed:
- sdk_v2/cpp/CMakeLists.txt
- sdk_v2/cpp/src/inferencing/model_load_manager.* and model_session_lease.h
- sdk_v2/cpp/src/inferencing/generative/{audio,chat,embeddings}/**
- sdk_v2/cpp/src/inferencing/session/**
- sdk_v2/cpp/src/manager.cc and sdk_v2/cpp/src/service/** handlers
- sdk_v2/cpp/test/CMakeLists.txt and focused internal cancellation tests
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 16cc8b6f-2bc4-4469-bf59-f21439569349
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Follow-up to #994. This contains the larger per-operation cancellation runtime that was removed from #994 to keep the original fix focused and reviewable.
It addresses the deferred concurrency/lifetime findings around request epochs, per-operation deadlines, generator ownership, session destruction, and concurrent embeddings cancellation.
This PR is intentionally draft and must not block #994.