chore: bump syn from 2.0.118 to 3.0.2 - #589
Conversation
Bumps [syn](https://github.com/dtolnay/syn) from 2.0.118 to 3.0.2. - [Release notes](https://github.com/dtolnay/syn/releases) - [Commits](dtolnay/syn@2.0.118...3.0.2) --- updated-dependencies: - dependency-name: syn dependency-version: 3.0.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the Rust dependency on syn, apparently attempting a major-version upgrade.
Changes:
- Bumped
synfrom2.0.111to3.0.2inCargo.toml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot, do a proper migration |
…o syn 3.x - Remove darling dependency from templated_uri_macros_impl (darling uses syn 2.x) - Replace darling's FromAttributes/FromField with manual syn 3.x parsing - Add required syn features to templated_uri_macros_impl Cargo.toml - Bump prettyplease from 0.2.37 to 0.3.0 (syn 3.x compatible) - Fix TypeGroup struct literal in thread_aware_macros_impl tests (new attrs field in syn 3.x)
Done. Here's what the proper migration involved (commit
All crates build and tests pass. The only remaining syn 2.x in the lockfile is from external transitive dependencies ( |
|
I think is a case where we should wait for crates that depend on new syn 3.0 to catch-up and then do the switch. No need to rush. For example, darling is already being upgraded: |
|
A newer version of syn exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
@copilot, rebase the branch and fix all conflicts |
Done. Merged
|
|
🛡️ Build Sentinel — marked ready-for-review to trigger the full What this PR is: a real syn 2 → 3 major migration for the two proc-macro crates that were blocked on it ( Reviewer call-out (design): only these two crates adopt syn 3.0.2; the rest of the workspace still pulls syn 2.0.119 transitively (argh, etc.), so the lockfile now carries two syn majors until the rest of the ecosystem moves. Please sign off on that dual-version build cost, and review the migrated attribute-parsing logic for behavioral parity with the old Not merging — posting for owner review/approval. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
crates/templated_uri_macros_impl/src/struct_template.rs:58
- The missing-template diagnostic is currently emitted at
Span::call_site(), which can make the error hard to locate in user code. Prefer spanning it to the actual#[templated(...)]attribute when present (and adjust the message to refer to the nested meta key).
let input_template = input_template.ok_or_else(|| {
syn::Error::new(
proc_macro2::Span::call_site(),
"missing required `template` attribute in `#[templated(...)]`",
)
})?;
| smol = { version = "2.0.0", default-features = false } | ||
| static_assertions = { version = "1.1.0", default-features = false } | ||
| syn = { version = "2.0.111", default-features = false } | ||
| syn = { version = "3.0.2", default-features = false } |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
crates/templated_uri_macros_impl/src/struct_template.rs:58
- The "missing required
template" error is currently created withSpan::call_site(), which tends to point diagnostics at the macro call site/crate root rather than the actual#[templated(...)]attribute. Using the#[templated]attribute span (when present) will produce a more actionable error location for users.
let input_template = input_template.ok_or_else(|| {
syn::Error::new(
proc_macro2::Span::call_site(),
"missing required `template` attribute in `#[templated(...)]`",
)
Bumps syn from 2.0.118 to 3.0.2.
Release notes
Sourced from syn's releases.
... (truncated)
Commits
88ee7beRelease 3.0.2587bc20Merge pull request #2070 from dtolnay/emptyrange96801f7Allow Error::new_range at empty cursor range9dc16c9Merge pull request #2069 from dtolnay/prevspan1db76b7Align on using impl trait across all Error constructorsbfa1ebfMake Cursor::prev_span publicc6ac5e5Merge pull request #2068 from dtolnay/newrange1436454Add Error::new_range constructor taking Range<Cursor>123c148Release 3.0.1bc11dddMerge pull request #2067 from dtolnay/fastpeekDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)