chore(webview): generalize dialog bridge into SyncServer#41878
chore(webview): generalize dialog bridge into SyncServer#41878pavelfeldman wants to merge 1 commit into
Conversation
Turn the WebKit WebView DialogBridge into a generic SyncServer that
routes each handler under an unguessable guid path, so the endpoint
cannot be discovered by page-side scripts just by knowing the randomly
bound port. addHandler returns a disposable { endpoint, dispose } and
WVPage owns registering/unregistering its own dialog handler while
keeping the dialog-specific request interpretation.
0f78bf2 to
90f58d0
Compare
Test results for "tests 1"1 failed 3 flaky49965 passed, 1188 skipped Merge workflow run. |
Test results for "MCP"3 failed 7757 passed, 1249 skipped Merge workflow run. |
|
Hi, I'm the Playwright bot and I took a look at the failing CI. 🟢 The one failure is unrelated to this PR — CI is clearThe single red test is DetailsThis PR only refactors Pre-existing flake / infra
Also seen (already green)
Triaged by the Playwright bot - agent run |
|
Hi, I'm the Playwright bot and I took a look at the failing CI. 🟢 All failures are pre-existing flakes / infra — this PR is clearThis PR only refactors the WebKit WebView dialog bridge into DetailsPre-existing flake / infra
The MCP tools exercise Chrome/Chromium/CDP; a WebKit WebView Also seen (already green)
Triaged by the Playwright bot - agent run |
Summary
DialogBridgeinto a reusableSyncServer(JSON in / JSON out).WVPagenow owns registering/unregistering its own dialog handler and keeps the dialog-specific request interpretation.