feat(network): add request.waitForPostBody() for asynchronously reported bodies#41888
Draft
yury-s wants to merge 2 commits into
Draft
feat(network): add request.waitForPostBody() for asynchronously reported bodies#41888yury-s wants to merge 2 commits into
yury-s wants to merge 2 commits into
Conversation
Network.requestWillBeSent does not include post data entries when the request body is not available synchronously (e.g. a Blob or File body), only hasPostData is set. Retrieve the body via Network.getRequestPostData in that case, deferring the request events until the body is fetched. Fixes: microsoft#6479
…ted bodies Instead of deferring request dispatch while the body is fetched via Network.getRequestPostData, dispatch the request right away and push the body to the client once it is available. New request.waitForPostBody() resolves when the body has been reported by the browser. Fixes: microsoft#6479
Contributor
Test results for "MCP"1 failed 7759 passed, 1249 skipped Merge workflow run. |
Contributor
|
Hi, I'm the Playwright bot and I took a look at the CI failures here. 🟢 The one failure is a pre-existing flake — this PR is clear
DetailsOverall: 1 failed, 7759 passed. The single failure is unrelated to the diff and has a long flake history, so I don't see any CI signal attributable to this PR. Pre-existing flake / infra
Triaged by the Playwright bot - agent run |
Contributor
Test results for "tests 1"3 flaky50025 passed, 1193 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasPostDatafor Blob/File request bodies inNetwork.requestWillBeSent; fetch the body viaNetwork.getRequestPostDataand push it to the client asynchronouslyrequest.waitForPostBody()resolves once the body has been reported; syncpostData()/postDataBuffer()also return it after that pointFixes #6479