acl COSI files do not contain ospackages#707
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Trident’s COSI v1.1 metadata validation to allow Azure Container Linux (ACL) COSI files that omit osPackages, aligning validation with IC 1.5’s ACL VHD-to-COSI conversion behavior.
Changes:
- Updates v1.1 validation logic to treat missing
osPackagesas valid for ACL, while keeping per-packagerelease/archchecks when present. - Preserves the existing “osPackages required” validation for non-ACL variants.
Compare variant_id against osutils::osrelease::AZURE_CONTAINER_LINUX_VARIANT_ID instead of a hard-coded, allocated string, and add a regression test covering Azure Container Linux images that omit osPackages. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fintelia
approved these changes
Jul 13, 2026
frhuelsz
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 Description
IC 1.5 converts ACL vhds into COSI files that do not contain os_packages. Adjust Trident validation accordingly.
Trident Validation: https://dev.azure.com/mariner-org/ECF/_build/results?buildId=1158550&view=results
ACL Validation: https://dev.azure.com/mariner-org/ACL/_build/results?buildId=1158559&view=results