Skip bound method assignments in JS declaration emit

[Copilot]

JS declaration emit was synthesizing an extra property signature for constructor-bound methods, producing both a property and method declaration for the same class member.

export class C {
    constructor() {
        this.foo = this.foo.bind(this);
    }
    foo() {}
}

• Declaration emit

  • Resolve the assigned member access for this.x = ... before deciding whether to synthesize a JS property declaration.
  • Track seen instance/static member names so no-check declaration emit also skips members already declared on the class.

• Regression coverage

  • Added a compiler test for constructor-bound JS class methods.
  • Baselines now emit only:

export declare class C {
    constructor();
    foo(): void;
}

[weswigham]

@copilot rethink this - since collectThisPropertyAssignments already has a seen table it prepopulates with non-this. class members, rather than having a second (incorrectly scoped) table, just change the map key from *ast.Node directly to a composite key that contains either the string property name (for named members) or the node (for dynamically named members).

[weswigham]

And include a bit for instance vs static in said composite key - no need to use string concatenation.

[weswigham]

@copilot try again

[Copilot]

Addressed in 9cf60b3 by using a composite seen key with property name/node plus instance/static state.