Merge latest Library.Template by AArnott · Pull Request #1614 · microsoft/vs-threading

AArnott · 2026-07-08T14:02:15Z

Fix typo
Use preferred pattern for appending to PATH in GitHub Actions
Avoid loading GitHubActions.ps1 on Azure Pipelines
Validate Path parameter in Add-GitHubActionsEnvVariable
Fix 1ES PT nuget push
Update dependency dotnet-coverage to v18.9.0 (536)
Update dependency Microsoft.Testing.Extensions.CodeCoverage to 18.9.0 (537)

Use preferred pattern for appending to PATH in GitHub Actions

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

… (537) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…emplate Specifically, this merges [3749d32 from that repo](AArnott/Library.Template@3749d32).

Copilot

Pull request overview

This PR merges the latest Library.Template updates into vs-threading, primarily improving CI scripting behavior across GitHub Actions and Azure Pipelines, and bumping code-coverage-related dependencies.

Changes:

Updated GitHub Actions PATH handling to use $GITHUB_PATH (via a new helper) instead of overwriting PATH through $GITHUB_ENV.
Avoided loading GitHubActions-specific helper functions in non-GitHub-Actions contexts for the variables definition script.
Bumped code coverage tool/package versions and adjusted Azure Pipelines agent image selection for NuGet push.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tools/variables/_define.ps1	Only loads GitHub Actions helpers when running under GitHub Actions.
tools/Set-EnvVars.ps1	Switches PATH propagation in GitHub Actions to use `$GITHUB_PATH` via `Add-GitHubActionsPath`.
tools/GitHubActions.ps1	Adds validation for env file path and introduces `Add-GitHubActionsPath` helper.
Directory.Packages.props	Updates `Microsoft.Testing.Extensions.CodeCoverage` to 18.9.0.
azure-pipelines/release.yml	Pins the NuGet push job to Ubuntu 22.04 due to an external issue.
azure-pipelines/prepare-insertion-stages.yml	Pins the package push job to Ubuntu 22.04 due to an external issue.
.github/skills/bundle-dependency-prs/SKILL.md	Fixes a typo in documentation (“authord” → “authored”).
.config/dotnet-tools.json	Updates `dotnet-coverage` tool version to 18.9.0.

This reverts commit b5153f6. The dependency isn't allowed per CFS policy yet.

…emplate Specifically, this merges [e6e3c19 from that repo](AArnott/Library.Template@e6e3c19).

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

…emplate Specifically, this merges [65a9b52 from that repo](AArnott/Library.Template@65a9b52).

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

…emplate Specifically, this merges [bd12df8 from that repo](AArnott/Library.Template@bd12df8).

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

tools/Set-EnvVars.ps1:91

$CmdEnvScript appends a SET PATH line without a trailing CRLF. If $PrependPath contains more than one entry, the generated cmd script lines will run together and become invalid.

        }

        $CmdEnvScript += "SET PATH=$_$pathDelimiter%PATH%"
    }

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Apply the same fix as microsoft/vs-threading#1614 by using a net472-specific app config for the analyzer tests and adding a binding redirect for System.Text.Encodings.Web. This avoids the Windows CI assembly load failure when the analyzer test harness restores reference-assembly packages. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Update Dockerfile and global.json updates (532) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update Microsoft Testing Platform to 2.3.0 * Pin Microsoft.Testing.Extensions.Telemetry to the common MTP version * Use preferred pattern for appending to PATH in GitHub Actions * Avoid loading GitHubActions.ps1 on Azure Pipelines * Validate Path parameter in Add-GitHubActionsEnvVariable * Update dependency dotnet-coverage to v18.9.0 (536) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency Microsoft.Testing.Extensions.CodeCoverage to 18.9.0 (537) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Prevent empty paths from being added to the PATH * Fix up error messages * Avoid importing GitHubActions.ps1 outside GitHub Actions * Update script synopsis * Clarify what looks like bad wording * Keep runtime package pins unchanged Restore the non-test System.IO.Pipelines and System.Text.Json package pins in Directory.Packages.props so the shared runtime dependencies continue following the intent of the existing code comment. Keep the newer 10.0.8 versions scoped to test projects and benchmarks, where the updated test infrastructure requires them. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Use runtime STJ version in analyzer references Align the net472 analyzer test reference assemblies with the non-test System.Text.Json package pin instead of the test-only override. This avoids the clean-runner assembly load failure in NuGet.Protocol when the analyzer tests resolve reference packages on Windows. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Add net472 config for analyzer tests Apply the same fix as microsoft/vs-threading#1614 by using a net472-specific app config for the analyzer tests and adding a binding redirect for System.Text.Encodings.Web. This avoids the Windows CI assembly load failure when the analyzer test harness restores reference-assembly packages. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: 🤖 Copilot <no-reply@github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

AArnott and others added 13 commits July 7, 2026 16:25

Fix typo

4299650

Use preferred pattern for appending to PATH in GitHub Actions

90ac1ee

Merge pull request #535 from AArnott/update-path-handling

6320f43

Use preferred pattern for appending to PATH in GitHub Actions

Merge remote-tracking branch 'origin/main' into microbuild

e1c8aa4

Avoid loading GitHubActions.ps1 on Azure Pipelines

5a0a13f

Merge branch 'main' into microbuild

def42bc

Validate Path parameter in Add-GitHubActionsEnvVariable

097060a

Merge branch 'main' into microbuild

b182ee0

Fix 1ES PT nuget push

5cd226a

Update dependency dotnet-coverage to v18.9.0 (536)

b5153f6

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update dependency Microsoft.Testing.Extensions.CodeCoverage to 18.9.0…

42c5cea

… (537) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into microbuild

3749d32

Merge the microbuild branch from https://github.com/aarnott/Library.T…

7fd71bd

…emplate Specifically, this merges [3749d32 from that repo](AArnott/Library.Template@3749d32).

Copilot AI review requested due to automatic review settings July 8, 2026 14:02

Copilot started reviewing on behalf of AArnott July 8, 2026 14:02 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

AArnott added 2 commits July 8, 2026 08:23

Revert "Update dependency dotnet-coverage to v18.9.0 (536)"

e6e3c19

This reverts commit b5153f6. The dependency isn't allowed per CFS policy yet.

Merge the microbuild branch from https://github.com/aarnott/Library.T…

af2b234

…emplate Specifically, this merges [e6e3c19 from that repo](AArnott/Library.Template@e6e3c19).

Copilot AI review requested due to automatic review settings July 8, 2026 14:25

Copilot started reviewing on behalf of AArnott July 8, 2026 14:26 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Comment thread tools/GitHubActions.ps1

Comment thread Directory.Packages.props

Comment thread azure-pipelines/release.yml Outdated

Comment thread azure-pipelines/prepare-insertion-stages.yml Outdated

AArnott added 4 commits July 8, 2026 08:42

Prevent empty paths from being added to the PATH

c43fba6

Merge branch 'main' into microbuild

65a9b52

Fix package restore failures

21218ea

Merge the microbuild branch from https://github.com/aarnott/Library.T…

56d6360

…emplate Specifically, this merges [65a9b52 from that repo](AArnott/Library.Template@65a9b52).

Copilot AI review requested due to automatic review settings July 8, 2026 14:51

Copilot started reviewing on behalf of AArnott July 8, 2026 14:51 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Comment thread tools/variables/_define.ps1

Comment thread tools/Set-EnvVars.ps1

Comment thread azure-pipelines/release.yml Outdated

Comment thread azure-pipelines/prepare-insertion-stages.yml Outdated

Fix up error messages

a4d4554

AArnott enabled auto-merge July 8, 2026 15:17

AArnott added 6 commits July 8, 2026 09:18

Avoid importing GitHubActions.ps1 outside GitHub Actions

8201f77

Merge branch 'main' into microbuild

6ab1b59

Clarify yml comment

3ee5eeb

Update script synopsis

3948cdc

Merge branch 'main' into microbuild

bd12df8

Merge the microbuild branch from https://github.com/aarnott/Library.T…

6677527

…emplate Specifically, this merges [bd12df8 from that repo](AArnott/Library.Template@bd12df8).

Copilot AI review requested due to automatic review settings July 8, 2026 15:23

Copilot started reviewing on behalf of AArnott July 8, 2026 15:23 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Comment thread azure-pipelines/release.yml

Comment thread azure-pipelines/prepare-insertion-stages.yml

Comment thread tools/GitHubActions.ps1

Copilot AI review requested due to automatic review settings July 8, 2026 17:00

Copilot started reviewing on behalf of AArnott July 8, 2026 17:00 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Comment thread tools/GitHubActions.ps1

Comment thread azure-pipelines/release.yml

Comment thread azure-pipelines/prepare-insertion-stages.yml

Fix failing analyzer tests

041558c

AArnott force-pushed the dev/andarno/libtemplateUpdate branch from d8976e9 to 041558c Compare July 8, 2026 17:09

Copilot AI review requested due to automatic review settings July 8, 2026 17:09

Copilot started reviewing on behalf of AArnott July 8, 2026 17:09 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Bring CONTRIBUTING into better conformance

e803450

Copilot AI review requested due to automatic review settings July 8, 2026 17:12

Copilot started reviewing on behalf of AArnott July 8, 2026 17:13 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Comment thread tools/GitHubActions.ps1

SylviaLe191 approved these changes Jul 8, 2026

View reviewed changes

AArnott merged commit 55c55a9 into main Jul 8, 2026
9 checks passed

AArnott deleted the dev/andarno/libtemplateUpdate branch July 8, 2026 18:23

Uh oh!

Conversation

AArnott commented Jul 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants